Skip to content
Snippets Groups Projects

Check for pipelines when setting page_gutter_class.

Merged username-removed-408230 requested to merge pipelines-layout-regression into master

What does this MR do?

Fixes regression issue related to the MR window sliding behind the right sidebar on page refresh.

Are there points in the code the reviewer needs to double check?

I'm getting stuck thinking about if/how to test this. Or maybe it just deserves a note somewhere about remembering to update page_gutter_class when a new route is added?

Why was this MR needed?

This regression prevented users from using many features of the MR view.

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/21121

Screenshots (if relevant)

Before: Screen_Shot_2016-08-23_at_11.08.04_AM

After: Screen_Shot_2016-08-23_at_11.07.46_AM

Does this MR meet the acceptance criteria?

cc: @jschatz1

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading