Restore get_id in ExtractsPath

fixes #21334 (closed)

Addressable::URI.normalize_component() around get_id which was introduced by 68cea38e and removed in !5878 (merged) is still intentionally omitted. Using normalize_component() instead of unescape() left % as is but still broke e.g. spaces (which were replaced by %20).

mentioned in merge request !5933 (merged)

Restored source branch restore-get_id

Changed title: Restore get → Restore get_id in ExtractsPath

Added 1 commit:

• 98b40513 - Restore get_id in ExtractsPath

Resolved all discussions

Resolved all discussions

Added 1 commit:

• 8087b134 - Restore get_id in ExtractsPath

Added 1 commit:

• ddbdf4e6 - Restore get_id in ExtractsPath

@smcgivern Build passed, can you review again?

Reassigned to @smcgivern

LGTM, thanks for taking this on. @DouweM do we want to add Pick into Stable for this as it's the proper way to fix the issue?

Reassigned to @DouweM

Added ~164274 label

@smcgivern Meh, the current fix works, let's not get more into stable that needs to be .

How about Pick into Unstable then?

And yes, I agree. If it ain't broke, don't fix it.

Reassigned to @winniehell

Resolved all discussions