Added subnav to all views bar issuable views

What does this MR do?

Adds subnav to all views apart from issue and MR views. The full list is available in screenshots below.

It also adds some JS to the builds page to simply handle the repositioning of the fixed position sidebar with the addition of the subnav.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

UX and apparently regression .

What are the relevant issue numbers?

Closes #18844 (closed).

Screenshots (if relevant)

Label

Edit

New

Milestone

Edit

New

Show

Commit

Show

Builds

Blob

Blame

Edit

Pipelines

Show

Show build

Edit Envrionment

Does this MR meet the acceptance criteria?

• CHANGELOG entry added
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the style guides
• Branch has no merge conflicts with master (if you do - rebase it please)
• Squashed related commits together Closes #18844 (closed)

mentioned in issue #20946 (closed)

Reassigned to @jschatz1

Added ~149423 label

Reassigned to @annabeldunstone

@annabeldunstone Can you review ?

mentioned in issue #18844 (closed)

Reassigned to @lbennett

I'll /assign @annabeldunstone when I've confirmed the subnav is everywhere we need it to be. :)

I can give you list of pages that should not have subnav:

• issue show page
• issue new page
• issue edit page
• merge request show page
• merge request new page
• merge request edit page

Changed title: Added subnav to labels edit+new and milestones edit+new+show → Added subnav to all views bar issuable views

Added 1 commit:

• f54ae17b - Added subnav to blame show, blob edit, builds show, commit builds, commit show, …

Reassigned to @annabeldunstone

Phewey that's a big one.

/cc @annabeldunstone @dzaporozhets

@lbennett thanks! :) looks good btw.

Nice @lbennett!
Just two things:

1. Since we have the subnav on the show and edit environment page, shouldn't we also show it on the new environment page?
2. When you expand the right sidebar on the builds page, the subnav goes off-center. I'm not actually sure how that page is going to work since the subnav isn't fixed but the sidebar is.
   

Reassigned to @lbennett

One more thing- these new subnavs should scroll on mobile but they currently look like this:

We recently made some updates to subnav scrolling here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5762

@annabeldunstone

shouldn't we also show it on the new environment page

Whoops! Thats in now. :)

expand the right sidebar on the builds page, the subnav goes off-cente

Fixed that up with a191aafd, let me know if its a bad solution.

these new subnavs should scroll on mobile

Rebased and looks great :)

Added 187 commits:

• f54ae17b...0693fee2 - 183 commits from branch master
• 88908a19 - Added subnav to labels edit+new and milestones edit+new+show
• e67f1c15 - Added subnav to blame show, blob edit, builds show, commit builds, commit show, …
• 801d51fc - Added subnav to new enviro view
• a191aafd - corrected build subnav

Added 1 commit:

• d1298335 - corrected build subnav

@dzaporozhets what do you think about the builds page? This would be the only place where we have a fixed element (the side nav) covering up a portion of the sub nav. It looks a little strange but I'm not sure what a better solution would be.