Skip to content

lib/backup: fix broken permissions when creating repo dir

What does this MR do?

This MR fixes an issue where gitlab:backup:restore will not work because the repositories directory is set up with bad permissions. The bad permissions will prevent access to the repositories by the git user, causing all kinds of troubles (e.g. gitlab-shell won't install hooks).

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Rake task gitlab:backup:restore would complete successfully, but gitlab:check will report errors and gitlab cannot access repos.

Screenshots (if relevant)

  • repositories.old.1472478726 was created without the fix
  • repositories was created with the fix

gitlab-repo-permissions

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports