Pass the full project path for resolve buttons
What does this MR do?
The full project path is passed from the HTML into the JS rather than the resolve button JS generating the URL based on the the namespaces.
@smcgivern @stanhu Do we have anyway of adding tests for installs with relative URLs?
What are the relevant issue numbers?
Closes #21704 (closed)
Merge request reports
Activity
mentioned in issue gitlab-qa#12
Unfortunately, I don't think we have a great way of testing relative URLs yet. At one point I added some test harness in rspec to test relative URLs, but the whole suite would have to be re-run with a custom environment variable. I've added an issue to gitlab-qa#12 to test this in the integration tests. If you have any other ideas how we can better to do this (e.g. via rspec), please let me know.
Added 1 commit:
- 42d37c86 - Fixed comment & resolve button
Added 25 commits:
-
42d37c86...08ab410f - 23 commits from branch
master
- 69e0e695 - Pass the full project path for resolve buttons
- 4bf98ff0 - Fixed comment & resolve button
-
42d37c86...08ab410f - 23 commits from branch
mentioned in issue #20946 (closed)
Reassigned to @fatihacet
Added 194 commits:
-
4bf98ff0...fe3d94e8 - 192 commits from branch
master
- aed07cb2 - Pass the full project path for resolve buttons
- 273d34b3 - Fixed comment & resolve button
-
4bf98ff0...fe3d94e8 - 192 commits from branch
Added 1 commit:
- ffa1b5b6 - Fixed comment & resolve button
- Resolved by Phil Hughes
@alfredo1 Could you please review this merge request since @fatihacet is unavailable?
- Resolved by Phil Hughes
- Resolved by Phil Hughes
@iamphill can you fix the conflicts? not sure if this is going into
8.11
though.Reassigned to @iamphill
Milestone changed to %8.12
Added 861 commits:
-
ffa1b5b6...6df3dd9d - 858 commits from branch
master
- 5461a5d1 - Pass the full project path for resolve buttons
- 1f49b99a - Fixed comment & resolve button
- 55a4af5e - Changed props to use strings
Toggle commit list-
ffa1b5b6...6df3dd9d - 858 commits from branch
Added 1 commit:
- a83262ff - Changed props to use strings
Reassigned to @jschatz1
Nice job @iamphill
Mentioned in commit ab496d82
Mentioned in issue #22556 (closed)
Mentioned in commit 56dc3e4b