Skip to content
Snippets Groups Projects

Added a preference for choosing the default view for project issues

What does this MR do?

Adds a dropdown to the user's profile preferences, allowing the user to choose a default view for the project's issues.
The user can choose either the issues list, or the new board view.

The choice is reflected by dynamically changing the link to the Issues page in project views.

Are there points in the code the reviewer needs to double check?

There may be a better way to do the changes in app/views/layouts/nav/_project.html.haml
Please let me know if so.

I also had trouble finding the correct existing test suites to add tests to.

Why was this MR needed?

In addition to the points outlined in #21304 (moved), the new board view is very useful, to the point of superseding the issues list.
This MR allows the user to skip the issues list.

Screenshots (if relevant)

Before

Before

After

After

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #21304 (moved)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @AntiPaste! I know this is still marked WIP, but I was pretty excited by the feature 😃

    I also had trouble finding the correct existing test suites to add tests to.

    We have specs for the default project view here, it seems like we could add some for the issues view too: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/features/projects_spec.rb

  • Added ~164274 label

  • Added 5 commits:

    • 0803563f - Re-add downtime specification
    • 93c5ea6e - Changed documentation grammar
    • 3aab48c4 - Remove rubocop notation on migration
    • 06609eba - Move changelog line to middle and add attribution
    • f7cf170d - Added tests
  • Hey @smcgivern, thanks for the comments!

    I fixed the issues you highlighted. I guess I was being too careful by copying the exact way stuff was done in the past (migration, documentation). 😅 First time contributing to a major open-source project!

    I added tests as well and for the first time the CI build is passing. I'll squash the commits and push for the last time before removing the WIP tag.

  • Added 1 commit:

    • fd05d5e6 - Added a preference for choosing the default view for project issues
  • username-removed-552726 Marked the task All builds are passing as completed

    Marked the task All builds are passing as completed

  • username-removed-552726 Marked the task Added for this feature/bug as completed

    Marked the task Added for this feature/bug as completed

  • Added 131 commits:

    • fd05d5e6...f90c6a24 - 130 commits from branch gitlab-org:master
    • aeaef10c - Added a preference for choosing the default view for project issues
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading