Skip to content
Snippets Groups Projects

Fixed slash commands not loading

Merged Phil Hughes requested to merge slash-commands-load-fix into master
All threads resolved!

What does this MR do?

Fixes an issue with slash commands not working when the autocomplete source is loading & then the new issue button is clicked. This also fixes an issue where the autocomplete source is loaded on pages where it isn't actually needed.

What are the relevant issue numbers?

Closes #21774 (closed), #21807 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Phil Hughes Added 1 commit:

    Added 1 commit:

  • Phil Hughes Added 69 commits:

    Added 69 commits:

  • @iamphill I still see unresolved discussions. Still says one out of two discussions resolved. Resolve those and assign to me.

  • Reassigned to @iamphill

  • Robert Speicher Resolved all discussions

    Resolved all discussions

  • Reassigned to @jschatz1

  • Added ~584040 label

  • Reassigned to @iamphill

  • Phil Hughes Added 452 commits:

    Added 452 commits:

    • 8799aed9...7ac47516 - 447 commits from branch master
    • 3531032e - Fixed slash commands not loading
    • a5035ed3 - Correctly loads gfm autocomplete source on pages where it is required
    • cd9a2ba1 - Fixed group milestone error
    • 9c5638fb - Use admin user in tests
    • b66a8203 - Moved loading GFM source into zen.html.haml
  • Phil Hughes Resolved all discussions

    Resolved all discussions

  • Reassigned to @jschatz1

  • username-removed-128633 Resolved all discussions

    Resolved all discussions

  • Robert Speicher Added ~149423 label

    Added ~149423 label

  • @jschatz1 Going to steal this one from you, I think it's good to go.

  • Reassigned to @rspeicher

  • Robert Speicher Status changed to merged

    Status changed to merged

  • Robert Speicher Mentioned in commit cbb9507c

    Mentioned in commit cbb9507c

  • Picked into 8-12-stable, will go into RC7.

  • Rubén Dávila Removed ~149423 label

    Removed ~149423 label

  • Robert Speicher Mentioned in commit c525ec9b

    Mentioned in commit c525ec9b

  • Robert Speicher Mentioned in merge request !6569 (merged)

    Mentioned in merge request !6569 (merged)

  • Stan Hu Mentioned in issue #22827 (closed)

    Mentioned in issue #22827 (closed)

  • Please register or sign in to reply
    Loading