Refactored less readable existance checks
requested to merge jlogandavison/gitlab-ce:21988-refactor-less-readable-existance-checking-code-from-coffeescript into master
What does this MR do?
Clean up complex JavaScript expressions generated by conditional assignment and existence checks in CoffeeScript. These are small changes that effect 1 or 2 lines at a time, but should make sections of code more readable.
Are there points in the code the reviewer needs to double check?
Changes in gl_dropdown.js don't do much (largely just splitting stuff onto multiple lines). Is this a bit pointless?
Why was this MR needed?
Auto-generated JS contains complex expressions that will be difficult to work with in future.
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
All builds are passing -
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
A child issue of #21887 (closed) Closes #21988 (closed)