Something went wrong while fetching the environments for this merge request. Please try again.
Fixed awards dropdown search text from repeating
What does this MR do?
Thanks @zeiv for this!
This fixes #20463 (closed) by adding the .emoji-search class to the "Search results" h5 element. AwardsHandler.prototype.setupSearch() was trying to remove the element before creating a new one, but wasn't because the it was attempting to select it with the .emoji-search class, which wasn't being added.
Are there points in the code the reviewer needs to double check?
I don't believe so.
Why was this MR needed?
See #20463 (closed)
(and #22525 (closed))
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #22525 (closed)
Merge request reports
Activity
Please register or sign in to reply