Changed compare dropdowns to dropdowns with search input
What does this MR do?
This changes the compare dropdowns from text inputs, that when clicked, open a dropdown of branches/tags to dropdowns that have a dropdown toggle and an isolated search input.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
This was needed to fix the poor UX highlighted in #22221 (closed), where opening the dropdown showed an initially filtered set of results because the dropdown toggle was the dropdown filter itself. The compare page is always loaded with master as each branch/tag selection, so when opening the dropdown, it would only show results matching master.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #22221 (closed)
Merge request reports
Activity
Mentioned in issue #22011 (closed)
Added 1 commit:
- 7bebc860 - Updated compare specs
Added 1 commit:
- 0d1fa878 - Changed compare dropdowns to dropdowns with isolated search input
Reassigned to @fatihacet
@lbennett This isn't responsive
Reassigned to @lbennett
Looks like this isn't responsive originally and it definitely needs some UX love. :) Will do my best to pretty it up in this MR however :)
Thanks for catching this!
Mentioned in issue #22786 (moved)
Added 1 commit:
- c70db581 - Added temporary responsive design
-
What do you think about this? It looks weird with the text off-center because of the grey input addons.
I could write JS to correct this but I'm not sure there is much point when I've requested a redesign in #22786 (moved).
Reassigned to @fatihacet
@lbennett Tested this is my local works good looks quite good enough for merge.
@hazelyang can you work on the responsive design and let us know so we can update it.
Mentioned in commit 60b92c55
@fatihacet @lbennett Responsive design for this page.
Mentioned in issue #22879 (moved)
@hazelyang that looks awesome
Mentioned in issue #22800 (closed)
