Refactor TrendingProjectsFinder to support caching (!6672) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

yorickpeterse-staging requested to merge trending-caching into master Oct 04, 2016

What does this MR do?

This refactors TrendingProjectsFinder so it can support caching of the data. See cb7d3989 for more details.

Are there points in the code the reviewer needs to double check?

The usual.

Why was this MR needed?

Trending projects is quite slow, easily taking seconds to load the entire page.

Does this MR meet the acceptance criteria?

CHANGELOG entry added
Tests
- Added for this feature/bug
- All builds are passing
Conform by the merge request performance guides
Conform by the style guides
Branch has no merge conflicts with master (if you do - rebase it please)
Squashed related commits together

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/22164

https://gitlab.com/gitlab-com/infrastructure/milestones/4, in particular the section "Trending page under 2s"