Skip to content
Snippets Groups Projects

Improve the contribution and MR review guide

Merged Improve the contribution and MR review guide
improve-contributing into master
1 unresolved thread
Merged username-removed-128633 requested to merge improve-contributing into master
1 unresolved thread

What does this MR do?

This merge request improves the contributing and MR review guides following @stanhu's reply on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6096#note_16537211.

Why was this MR needed?

To clearly state that MR reviews can take multiple iterations but that as reviewers we should do our best to minimize the number of iterations and take over any MR that is set as "Merge when build succeeds" at some point.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
doc/development/code_review.md
34 34
35 35 ## Having your code reviewed
36 36
37 Please keep in mind that code review is a process that can take multiple
38 iterations, and reviewer may spot things later that they may not have seen the
  • Robert Speicher
    Robert Speicher @rspeicher ·
    Owner

    @rymai One note, but good changes. :thumbsup:

  • username-removed-128633
    username-removed-128633 @rymai ·
    Author Maintainer

    Thanks @rspeicher, I've pushed 52ca9bf6 to fix the typo and I've added the MWBS acronym because that was confusing me (and Google was not helpful here)!

  • username-removed-128633 Added 1 commit:

    Added 1 commit:

    • 52ca9bf6 - Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
  • Stan Hu Status changed to merged

    Status changed to merged

  • Stan Hu Mentioned in commit 48099e07

    Mentioned in commit 48099e07

  • Stan Hu
    Stan Hu @stanhu ·
    Maintainer

    Thanks for the revisions @rymai!

    • Please register or sign in to reply