Add Nofollow for uppercased external url protocols
requested to merge the-undefined/gitlab-ce:22782-external-link-filter-with-non-lowercase-scheme into master
What does this MR do?
Fixing #22782 (closed) by updating the Banzai::Filter::ExternalLinkFilter to consider urls with non-lowercase protocols (hTTp etc) as external links.
Are there points in the code the reviewer needs to double check?
Internal links with non-lowercase protocols will also be skipped, this seemed like a simple edge case to adopt in this change.
Why was this MR needed?
To cover some instances of auto-generated, or mistyped, links not being treated as external urls.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added - [-] Documentation created/updated
- [-] API support added
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #22782 (closed)