Skip to content
Snippets Groups Projects

Make autocomplete request performant

Merged Luke "Jared" Bennett requested to merge 18435-autocomplete-is-not-performant into master

What does this MR do?

Restricts the autocomplete_sourcesaction to returning the jsonof one specific at type at a time.

Makes sure all commands start by immediately showing the loading dropdown.

If the loading dropdown is active, we will request and load in the data for that specific at type. We manually trigger the filter again. This time, if loading dropdown is not active, initiate default filter behaviour and use the correct data template.

Also fixes an issue where setup was called multiple times by only setting up and destroying atwho on a focused/blured input.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

autocomplete_sources was requested on page load and is large.

Screenshots (if relevant)

3 requests for 3 different first-time references.

Screen_Shot_2016-10-14_at_14.43.12

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #22802 (closed)

Closes #18435 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading