Skip to content
Snippets Groups Projects

Fix Hash syntax to work for both Ruby 2.1 and 2.3

Merged Stan Hu requested to merge sh-fix-ruby-2-1 into master

Ruby 2.1 specs were failing (e.g. https://gitlab.com/gitlab-org/gitlab-ce/builds/5149275) due the error:

SyntaxError: /builds/gitlab-org/gitlab-ce/app/views/devise/shared/_tabs_normal.html.haml:3: syntax error, unexpected ':', expecting =>
...'#login-pane', data: {'toggle':'tab'}, role: 'tab')).to_s));...

Merge request reports

Pipeline #4622127 failed

Pipeline failed for fa25f61d on sh-fix-ruby-2-1

Merged by avatar (Apr 23, 2025 8:40pm UTC)

Loading

Pipeline #4622303 failed

Pipeline failed for a7e9490d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading