LDAP login style fixups
What does this MR do?
- Addresses regression found here: https://gitlab.com/gitlab-org/gitlab-ce/issues/23435
- Adds border radius to left/right tabs
cc: @dblessing @rymai @eReGeBe
Are there points in the code the reviewer needs to double check?
So you know what you're seeing, there are three types of fixes going on here:
- Template syntax errors that were displaying template-like language in the DOM (specifically with ldap and crowd username labels
- Aesthetic problems in tabs that arise with more than 2 tabs
- LDAP and crowd tab functionality. I had to move each panel into its own login box, to ensure that each panel's id synced with its associated tab's href, and that each panel was at an equal depth within the DOM. I assumed bootstrap tabs would look deeper into the login-box to find panels that matched the tabs. This is not true. The reason I didn't catch this is that in development I was just manually changing template flags to force rendering. I didn't realize I could enable ldap in CE within the gitlab.yml file
🤦
Why was this MR needed?
Screenshots (if relevant)
(disregard grey input borders... this is a weird bug in gifox)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together