Skip to content

Fix clone URL losing selection after a single click in Safari and Chrome

Stan Hu requested to merge stanhu/gitlab-ce:fix-safari-clone-url into master

What does this MR do?

This MR deactivates the mouseup event in the git clone URL to prevent the text from being deselected after a single click.

Why was this MR needed?

In Safari and Chrome 43.0.2357.65 (42.0.2311.152 worked fine), the URL would lose selection after a single click. To reproduce:

  1. Go to https://gitlab.com/gitlab-org/gitlab-ce
  2. Click on the URL in the repository (HTTP is selected by default).
  3. Click on the SSH button.
  4. Click on the URL again.

The URL selection should be selected automatically, but it is deselected immediately.

It appears that 92544df8 changed the selection event from click to focusin to make copy & paste work in X11. This Stack Overflow article discusses the deselection issue in detail:

http://stackoverflow.com/questions/3380458/looking-for-a-better-workaround-to-chrome-select-on-focus-bug

What are the relevant issue numbers?

Closes https://github.com/gitlabhq/gitlabhq/issues/9326

Merge request reports