Skip to content

[WIP] Fix browsing of issues and merge requests by milestone ID

Stan Hu requested to merge stanhu/gitlab-ce:fix-milestone-issue-list into master

What does this MR do?

This MR adds support for using the milestone_id parameter to query for milestones.

Why was this MR needed?

If you click on the "Issues" or "Merge Requests" links from a milestone page (e.g. https://gitlab.com/gitlab-org/gitlab-ce/milestones), you get a list of all issues instead of the issues for that milestone. I'm not sure if this ever worked.

Are there points in the code the reviewer needs to double check?

  1. Does it make more sense to change milestone_id to milestone_title as it is done in other views?
  2. Does it make sense to support NONE for milestone_id? I made it consistent with milestone_title.

What are the relevant issue numbers?

#1669 (closed)

Merge request reports