Skip to content
Snippets Groups Projects

Add a bin/changelog script and changelog documentation

Merged Robert Speicher requested to merge rs-bin-changelog into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-443319
  • username-removed-128633
  • Thanks @rspeicher, I think we could be more explicit in the option names, and id -> merge_request but other than that, nothing major, I'm excited! :D

  • Added ~889916 label

  • Robert Speicher Resolved all discussions

    Resolved all discussions

  • Robert Speicher Added 2 commits:

    Added 2 commits:

    • cd6b76db - Update bin/changelog to use OptionParser
    • 21daaf5b - Update documentation for bin/changelog

    Compare with previous version

  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • bf9befec - Add fail_with method to bin/changelog

    Compare with previous version

  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • bf9befec - Add fail_with method to bin/changelog

    Compare with previous version

  • Thanks @rspeicher! What do you think about adding very simple specs for this?

  • @rymai I want to, yeah.

  • @rymai It'll probably have to be in a separate MR. Opened https://gitlab.com/gitlab-org/gitlab-ce/issues/23978.

    Edited by Robert Speicher
  • Reassigned to @rymai

  • Mentioned in issue #23978 (moved)

  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • 8305234e - Add specs for ChangelogOptionParser in bin/changelog

    Compare with previous version

  • @rymai Added some basic specs for the option parser to this MR.

    Edited by Robert Speicher
  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • e2140466 - Minor bin/changelog improvements

    Compare with previous version

  • Made some changes to the docs and rebased to squash commits, still waiting for that to show up here.

  • Reassigned to @rspeicher

  • Robert Speicher Marked this merge request as a Work In Progress

    Marked this merge request as a Work In Progress

  • Robert Speicher Added 10 commits:

    Added 10 commits:

    • 1dc69be2...49077651 - 7 commits from branch master
    • 03b932df - Add a bin/changelog script
    • 23312b48 - Add changelog documentation
    • 5acb3230 - Add specs for ChangelogOptionParser in bin/changelog

    Compare with previous version

  • @rymai Good to go!

  • Robert Speicher Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Reassigned to @rymai

  • username-removed-128633 Status changed to merged

    Status changed to merged

  • Mentioned in commit daca93c4

  • Since when are we adopting this method to add a CHANGELOG entry?

    Edited by username-removed-408881
  • @alfredo1 As soon as this was merged. :smiley:

  • Please register or sign in to reply
    Loading