Fixed sticky MR tabs positioning when sidebar is pinned (!7167) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged Phil Hughes requested to merge sticky-mr-tabs-pinned-nav into master 8 years ago

What does this MR do?

The sticky MR tabs where positioned underneath the pinned sidebar. This fixes that by accounting for the size of the pinned nav.

Screenshots (if relevant)

What are the relevant issue numbers?

Closes #23926 (closed)

Activity

username-removed-502136 @fatihacet 8 years ago

Contributor

@iamphill LGTM but conflicts
username-removed-502136 Reassigned to @iamphill 8 years ago

Reassigned to @iamphill
username-removed-502136 Added 65 commits: 8 years ago
Added 65 commits:

41dac81d...dcc699af - 64 commits from branch master

1c05332e - Fixed sticky MR tabs positioning when sidebar is pinned

Compare with previous version
username-removed-502136 @fatihacet 8 years ago

Contributor

@iamphill Rebased from master, resolved conflicts, force pushed and enabled auto merge. FYI.
username-removed-502136 Reassigned to @fatihacet 8 years ago

Reassigned to @fatihacet
username-removed-502136 Enabled an automatic merge when the build for 1c05332e succeeds 8 years ago

Enabled an automatic merge when the build for 1c05332e succeeds
username-removed-502136 Status changed to merged 8 years ago

Status changed to merged
username-removed-502136 Mentioned in commit b216d9bf 8 years ago

Mentioned in commit b216d9bf
username-removed-502136 Mentioned in commit d31fa260 8 years ago

Mentioned in commit d31fa260
Stan Hu Removed ~149423 label 8 years ago

Removed ~149423 label
Stan Hu @stanhu 8 years ago

Maintainer

Picked into 8-13-stable, will go into 8.13.2.
Stan Hu Mentioned in issue #23827 (closed) 8 years ago

Mentioned in issue #23827 (closed)

Please register or sign in to reply