Fix: Guest sees some repository details and gets 404

What does this MR do?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24056

What are the relevant issue numbers?

Closes #24056 (closed)

Mentioned in issue #24056 (closed)

@felipe_artur can you review this please?

Reassigned to @felipe_artur

@smcgivern Right solution!

Just need specs. I think better place to add them is to spec/features/projects/features_visibility_spec.rb.

Thanks @vsizov

Reassigned to @vsizov

I thought we only test happy path with "spec/features". On the other hand I see that we already tested negative cases there...

I looked at that spec/features/projects/features_visibility_spec.rb and it's a bit confusing to me that we test permissions in feature specs, I think it should be controller's specs instead as they are a lot cheaper. More over we use js: true there

Added 50 commits:

• 1b40f153...90072d61 - 49 commits from branch master
• 656429b3 - Fix: Guest sees some repository details and gets 404

Compare with previous version

Added 1 commit:

• 7f7c1719 - Fix: Guest sees some repository details and gets 404

Compare with previous version

Reassigned to @smcgivern

Enabled an automatic merge when the build for 7f7c1719 succeeds

FYI the build is messed up so it wasn't merged.

@adamniedzielski I just restarted it

Added 115 commits:

• 7f7c1719...73ab9ba5 - 114 commits from branch master
• dcd70453 - Fix: Guest sees some repository details and gets 404

Compare with previous version

rebased

Enabled an automatic merge when the build for dcd70453 succeeds

Status changed to merged

Mentioned in commit 856ef3c3

mentioned in issue #26064 (moved)