Improved ref switcher dropdown performance
What does this MR do?
Removes jQuery creating elements, instead uses vanilla JS to create elements. This increase the performance significantly, previously with ~500 branches render time was approx. 30ms, with this change it dropped down to approx. 5ms.
The JSON now returns a maximum of 100 branches & 100 tags. The user can then search for more if they require.
What are the relevant issue numbers?
Closes #18202 (closed)
Merge request reports
Activity
Added 98 commits:
-
69a5560e...d9cf5c0a - 95 commits from branch
master
- 017c6e72 - Improved ref switcher dropdown performance
- a85237d4 - Use cloneNode instead of createElement
- c940729f - Uses take rather than Kaminari
Toggle commit list-
69a5560e...d9cf5c0a - 95 commits from branch
Added 1 commit:
- d31e3a27 - Changed how the data is returned - we only care about the branch/tag name
Added 193 commits:
-
741e0bf1...76ff9fff - 188 commits from branch
master
- 66a4ec9d - Improved ref switcher dropdown performance
- 5aede09f - Use cloneNode instead of createElement
- ce83d20b - Uses take rather than Kaminari
- 4c2d7a5e - Changed how the data is returned - we only care about the branch/tag name
- 231c7874 - Fixed the active branch selected indicator
Toggle commit list-
741e0bf1...76ff9fff - 188 commits from branch
Reassigned to @jschatz1
Added 754 commits:
-
37ae276d...50b95f31 - 748 commits from branch
master
- 83197285 - Improved ref switcher dropdown performance
- ee1559f4 - Use cloneNode instead of createElement
- c4ebeb8a - Uses take rather than Kaminari
- b62ffd93 - Changed how the data is returned - we only care about the branch/tag name
- d40fc9eb - Fixed the active branch selected indicator
- ea080b84 - Fixed up tests
Toggle commit list-
37ae276d...50b95f31 - 748 commits from branch
Added 235 commits:
-
ea080b84...9aded5c8 - 229 commits from branch
master
- 39aa8fbc - Improved ref switcher dropdown performance
- 33441258 - Use cloneNode instead of createElement
- bcbf7222 - Uses take rather than Kaminari
- aea9f29e - Changed how the data is returned - we only care about the branch/tag name
- 058e523e - Fixed the active branch selected indicator
- 5466b8d7 - Fixed up tests
Toggle commit list-
ea080b84...9aded5c8 - 229 commits from branch
Added 156 commits:
-
728b664b...d17f5068 - 149 commits from branch
master
- 1a21fa26 - Improved ref switcher dropdown performance
- af02f6ae - Use cloneNode instead of createElement
- ba2089e0 - Uses take rather than Kaminari
- f9750b49 - Changed how the data is returned - we only care about the branch/tag name
- 08dd831f - Fixed the active branch selected indicator
- e95d43df - Fixed up tests
- 50d58c14 - Fixed protected branches dropdown
Toggle commit list-
728b664b...d17f5068 - 149 commits from branch
Reassigned to @iamphill
@iamphill great awesome MR!
this is failing almost every test. Let me know whence it is ready for me (when builds pass)Reassigned to @jschatz1
Milestone changed to %8.15
@jschatz1 all green
moved milestone to 8.15.