Skip to content
Snippets Groups Projects

Grapify subscription API

Merged username-removed-2900 requested to merge grapify-subscription-api into master
All threads resolved!

What are the relevant issue numbers?

Related to #22928 (moved)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @razer6, I had a couple of questions!

  • Reassigned to @razer6

  • Added 1 commit:

    Compare with previous version

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • Thanks @razer6, there are two failing specs following the last change:

      1) API::API POST /projects/:id/labels/:label_id/subscription when label_id is a label title subscribes to the label
         Failure/Error: expect(response).to have_http_status(201)
           expected the response to have status code 201 but it was 400
         # ./spec/requests/api/labels_spec.rb:216:in `block (4 levels) in <top (required)>'
    
      2) API::API DELETE /projects/:id/labels/:label_id/subscription when label_id is a label title unsubscribes from the label
         Failure/Error: expect(response).to have_http_status(200)
           expected the response to have status code 200 but it was 400
         # ./spec/requests/api/labels_spec.rb:258:in `block (4 levels) in <top (required)>'
  • @rymai I updated the MR. The problem is that label IDs are strings, whereas other ids are integers.

  • Added 1 commit:

    Compare with previous version

  • Reassigned to @rymai

  • username-removed-128633 Status changed to merged

    Status changed to merged

  • Mentioned in commit 763a89a3

  • mentioned in issue gitlab#6486

  • Please register or sign in to reply
    Loading