Add nested groups support to the routing
What does this MR do?
It allows routing with / in namespace name
Why was this MR needed?
For nested groups feature(https://gitlab.com/gitlab-org/gitlab-ce/issues/2772). We need URI like /group/subgroup/project be routed correctly
Does this MR meet the acceptance criteria?
-
Changelog entry added Documentation created/updatedAPI support added- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
Mentioned in merge request !7121 (merged)
Marked the task Changelog entry added as completed
Marked the task Squashed related commits together as completed
Marked the task Conform by the style guides as completed
Marked the task Conform by the merge request performance guides as completed
@DouweM can you please review this one? I decided to extract routing changes into separate merge request as its big enough and produces conflicts often.
Reassigned to @DouweM
Reassigned to @dzaporozhets
Added 328 commits:
-
4f87f0bd...964872eb - 327 commits from branch
master - 5695b9df - Add nested groups support to the routing
-
4f87f0bd...964872eb - 327 commits from branch
Added 39 commits:
-
3ebe9829...aea8baed - 38 commits from branch
master - 8cf1f29f - Add nested groups support to the routing
-
3ebe9829...aea8baed - 38 commits from branch
-
@DouweM ok should be better now
Reassigned to @DouweM
Reassigned to @dzaporozhets
-
@DouweM as discussed I made a change when route is not found and user is not logged in then redirect to login page. For change see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7459/diffs?diff_id=1532711&start_sha=8cf1f29f8b4086212357c78bdcb8f52046d78a9e
Added 446 commits:
-
bd751855...900999f8 - 445 commits from branch
master - 26323c2c - Add nested groups support to the routing
-
bd751855...900999f8 - 445 commits from branch
Added 11 commits:
-
26323c2c...220c258c - 10 commits from branch
master - c902649c - Add nested groups support to the routing
-
26323c2c...220c258c - 10 commits from branch
Mentioned in issue #2772 (closed)
Reassigned to @DouweM
Added 204 commits:
-
81dac3e7...b1b5060d - 203 commits from branch
master - cf816a9c - Add nested groups support to the routing
-
81dac3e7...b1b5060d - 203 commits from branch
Reassigned to @dzaporozhets
-
@DouweM should be good now.
Reassigned to @DouweM
Mentioned in commit a7a9db80
mentioned in issue #25158 (closed)
@dzaporozhets I think this broke some routing, e.g.:
Started GET "/groups/foo-group/labels/1/edit" for 127.0.0.1 at 2016-12-06 17:12:21 +0100 Processing by GroupsController#edit as HTML Parameters: {"id"=>"foo-group/labels/1"}-
@rymai yep. I made a fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7957
mentioned in merge request !10413 (merged)
