Skip to content
Snippets Groups Projects

Remove JSX/React eslint plugins.

Merged Luke "Jared" Bennett requested to merge remove-jsx-react-eslint-plugins into master

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @lbennett can you fix the code so that it obeys the updated comma-dangle rule instead of just disabling it, now that we know the reason? :smile:

    I think we can either put them all in one line or add a dangling comma

  • Luke "Jared" Bennett Resolved all discussions

    Resolved all discussions

  • Added 1 commit:

    • 0a3b5c00 - Remove JSX/React eslint plugins.

    Compare with previous version

  • LGTM, @fatihacet can you review and merge?

  • @lbennett Please add CHANGELOG.

  • @fatihacet Do we want a CHANGELOG for something like this? :o

  • Luke "Jared" Bennett Marked the task Conform by the merge request performance guides as completed

    Marked the task Conform by the merge request performance guides as completed

  • Luke "Jared" Bennett Marked the task Conform by the style guides as completed

    Marked the task Conform by the style guides as completed

  • Luke "Jared" Bennett Marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    Marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading