Support special characters in label auto-completion (!7524) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

username-removed-269379 requested to merge antapos/gitlab-ce:24473-autocomplete-special-chars into master Nov 17, 2016

What does this MR do?

Support special characters in label auto-completion

Enhances the label auto-completion at issue comments textarea to support:

selecting a label containing special characters from the label auto-completion list should enter the label enclosed in double quotes
the label auto-completion list should display the labels containing special characters without double quotes
when the cursor is on a label enclosed in double quotes the label auto-completion list should show up

Are there points in the code the reviewer needs to double check?

There is a TODO item that needs to be reviewed and discussed:

Remove duplication of the single word label pattern from "app/assets/javascripts/gfm_auto_complete.js.es6" which also exists in models/label.rb (Label#reference_pattern)

Does this MR meet the acceptance criteria?

Changelog entry added
Tests
- Added for this feature/bug
- All builds are passing
Conform by the merge request performance guides
Conform by the style guides
Branch has no merge conflicts with master (if it does - rebase it please)

What are the relevant issue numbers?

Closes #24473 (closed), #22032 (moved)