Absorb gitlab_git

Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/24374

I'd like to get this merged sooner rather than later, so no extra work is done on https://gitlab.com/gitlab-org/gitlab_git that would need to be backported. Right now, no cleanup or deduplication of the code has been performed; everything is left pretty much as it was so as not to disturb the beast.

Mentioned in merge request gitlab_git!134 (merged)

Added 1 commit:

• 15235df5 - Absorb gitlab_git @ 6b077df2b68158cf8e069e3ffd6359aff038a438

Compare with previous version

Added 1 commit:

• 573b632e - Absorb gitlab_git @ 6b077df2b68158cf8e069e3ffd6359aff038a438

Compare with previous version

@rspeicher Can you verify I'm not doing anything crazy? It doesn't need to go into 8.14, but I would like to have it in master sooner rather than later, so we can kill https://gitlab.com/gitlab-org/gitlab_git (by merging https://gitlab.com/gitlab-org/gitlab_git/merge_requests/134) before people continue working there.

Reassigned to @rspeicher

Milestone changed to %8.15

Curious to see how GitLab's RuboCop rules will react to this.

Added 1 commit:

• 23c8332f - Absorb gitlab_git @ 6b077df2b68158cf8e069e3ffd6359aff038a438

Compare with previous version

@DouweM Test failures.

I think we should rethink our strategy a bit here:

1. Add GitLab CE's .rubocop.yml and .rubocop_todo.yml to gitlab_git and fix those violations.
2. Update gitlab_git's specs to conform to the version of RSpec used by CE.
3. Remove rspec-its and rspec-mocks
4. Depending how involved it is, update specs to use programmatically-generated repository fixtures instead of the static one.
5. Absorb.

Reassigned to @DouweM

@DouweM Ping!

mentioned in issue #25871 (closed)

Completed 1-3 of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7536#note_18852426 in https://gitlab.com/gitlab-org/gitlab_git/merge_requests/136!

resolved all discussions

changed milestone to %8.16

I'll take this over.

closed

assigned to @rspeicher

mentioned in merge request !8447 (merged)

mentioned in merge request gitlab_git!134 (merged)

mentioned in issue gitlab-elasticsearch-git#6 (closed)