Added initial todo functionality to collapsed sidebar
What does this MR do?
Adds todo functionality to the collapsed sidebar in the issue and mr view
Are there points in the code the reviewer needs to double check?
it still needs:
-
check on accessibility aria stuff -
tooltip -
loading spinner icon should temp replace the icons -
should work/show state across states of sidebar (open/closed)
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #24805 (closed)
Merge request reports
Activity
Added frontend ~19492 labels
Mentioned in issue #24805 (closed)
Reassigned to @dimitrieh
@selfup could you give me a hand in this? :) I got it working, but not totally!
Reassigned to @selfup
woops updated stuff from the issue:
We want the following icon: http://fontawesome.io/icon/check-circle/ with a blue active state, that is persistent if a todo is added.
@dimitrieh Where are we with this MR?
We haven't changed the bell icon to a check mark so maybe we should keep the icon in the sidebar as a bell to match. Unless it's going to be updated with this mr...Based on feedback we got with our research, we should definitely update the icon in this mr
Users do not understand what the ‘Todos’ icon represents. It was mistaken for “unread messages” and “notifications”, not a task list which the user needs to action. This was further emphasized when one user remarked that once he had viewed an item, he expected it to automatically reduce his number of ‘Todos’. He didn’t understand why he needed to click ‘Done’.
Edited by Taurie Davismentioned in issue ux-research#3 (closed)
added 7784 commits
-
d2d866a2...8cc4a39b - 7783 commits from branch
master
- 9acfa635 - adds todo functionality to closed issuable sidebar and changes todo bell icon to check-square
-
d2d866a2...8cc4a39b - 7783 commits from branch
@tauriedavis @sarahod what do you think of:
vs
Currently it looks like this:
@iamphill could you help me out with this?
😺 it still needs:
- check on accessibility aria stuff
- tooltip
- loading spinner icon should temp replace the icons
- should work/show state across states of sidebar (open/closed)
added this information to description
Edited by Dimitrie Hoekstraassigned to @iamphill
added 7784 commits
-
d2d866a2...8cc4a39b - 7783 commits from branch
master
- 9acfa635 - adds todo functionality to closed issuable sidebar and changes todo bell icon to check-square
-
d2d866a2...8cc4a39b - 7783 commits from branch
@dimitrieh Ahhh! You have no idea how idea how long i've wanted this
😝 will look at it now!@iamphill you are a
⭐