Use :maximum instead of :within for length validators with a 0..N range (!7894) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged username-removed-128633 requested to merge 25209-improve-length-validators into master 8 years ago

All threads resolved!

/cc @adamniedzielski @grzesiek

Closes #25209 (closed)

Activity

username-removed-378947 @adamniedzielski started a thread on an old version of the diff 8 years ago

Resolved 8 years ago by Robert Speicher
Last reply by username-removed-128633 8 years ago

username-removed-128633 resolved all discussions 8 years ago

resolved all discussions

username-removed-128633 added 1 commit 8 years ago

added 1 commit

f136a982 - Use :maximum instead of :within for length validators with a 0..N range

Compare with previous version

username-removed-128633 added 1 commit 8 years ago

added 1 commit

62d5439e - Use :maximum instead of :within for length validators with a 0..N range

Compare with previous version

Robert Speicher resolved all discussions 8 years ago

resolved all discussions

Robert Speicher @rspeicher 8 years ago

Owner

@rymai LGTM. Do we use the is_within matcher anywhere anymore? It's a custom one that we should remove if not.

username-removed-128633 added 1 commit 8 years ago

added 1 commit

4e249d5b - Use :maximum instead of :within for length validators with a 0..N range

Compare with previous version

username-removed-128633 @rymai 8 years ago

Author Maintainer

@rspeicher Thanks, I removed the now unused matcher!

username-removed-128633 changed milestone to 8 years ago

changed milestone to %8.15

username-removed-128633 assigned to @rymai 8 years ago

assigned to @rymai

username-removed-128633 merged 8 years ago

merged

username-removed-128633 mentioned in commit 8 years ago

mentioned in commit 5186618b

Please register or sign in to reply