Skip to content
Snippets Groups Projects

Grapify the service API

Merged username-removed-2900 requested to merge grapify-service-api into master

Related to #22928 (moved)

@rymai I started to implement a hash containing all settings for the PUT update. Could you do a brief review for that approach before I finish the MR?

Merge request reports

Pipeline #5360125 passed

Pipeline passed for 8d0645c2 on grapify-service-api

Test coverage 90.33% from 1 job
Approval is optional

Merged by username-removed-128633username-removed-128633 8 years ago (Dec 12, 2016 5:54pm UTC)

Merge details

Pipeline #5364647 passed with warnings

Pipeline passed with warnings for 927a7556 on master

Test coverage 90.71% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-128633
  • Thanks @razer6! The hash approach with specific endpoints per service makes sense as soon as we have different params specification (e.g. for the PUT endpoint), otherwise I'd say let's try to have a generic endpoint with just a constraint on the :service_slug param (e.g. for the DELETE endpoint).

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • @rymai Thanks for the review. I updated the MR to include all available services. I only generate the PUT endpoint dynamically and leave the other generic ones.

  • username-removed-2900 resolved all discussions

    resolved all discussions

  • mentioned in issue #22928 (moved)

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • username-removed-128633
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading