Skip to content
Snippets Groups Projects

Add support for nested groups to admin routing

Merged username-removed-444 requested to merge dz-fix-admin-routes into master
All threads resolved!

What does this MR do?

Changes admin routing to work with wildcard namespace id. Since rails resources does not work well with / inside *id I need to replace resource with scope + match combo. As result some routing naming changed because resource put action names as prefix to the path while match always does suffix. As bonus I replaced admin_namespaces_projects_path with admin_projects_path.

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

To make nested groups work in admin area

Screenshots (if relevant)

no

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-444 resolved all discussions

    resolved all discussions

  • username-removed-444 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 6e36a9db - Add support for nested groups to admin routing

    Compare with previous version

  • username-removed-444 marked the task Conform by the style guides as completed

    marked the task Conform by the style guides as completed

  • username-removed-444 marked the task Conform by the merge request performance guides as completed

    marked the task Conform by the merge request performance guides as completed

  • username-removed-444 marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • username-removed-444 marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • @DouweM please review

  • username-removed-444 mentioned in merge request !7976 (closed)

    mentioned in merge request !7976 (closed)

  • added 34 commits

    Compare with previous version

  • username-removed-444 marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • mentioned in commit b70b9628

  • LGTM, might need an EE MR though!

  • Please register or sign in to reply
    Loading