Skip to content

Resolve "Clean up CSS for project alerts and flash notifications."

What does this MR do?

Cleans up CSS and html for alert stripes at the top of project pages.

Screenshots

Before:

Screen_Shot_2016-12-16_at_2.39.01_PM_copy

After:

Screen_Shot_2016-12-16_at_2.39.23_PM_copy

Are there points in the code the reviewer needs to double check?

In order to get multiple alerts to appear manually while testing, I simply added the following block to app/views/shared/_no_password.html.haml:


.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'

.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'

.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'

Why was this MR needed?

More alert-warning stripes are coming via the CI usage limits implementation in EE (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/965), and these layout margins and colors were becoming messy.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #25743 (closed)

Merge request reports

Loading