Primary navigation

Project

GitLab FOSS
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Jira
- Releases
- Model registry
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

!8198

Resolve "Wiki page delete does not trigger the webhook"

Review changes
Download
Patches
Plain diff

Merged Resolve "Wiki page delete does not trigger the webhook"

markglenfletcher1/gitlab-ce:19302-wiki-page-delete-does-not-trigger-the-webhook into master

Overview 24
Commits 3
Pipelines 6
Changes 10

Merged username-removed-419655 requested to merge markglenfletcher1/gitlab-ce:19302-wiki-page-delete-does-not-trigger-the-webhook into master 8 years ago

Overview 24
Commits 3
Pipelines 6
Changes 10

What does this MR do?

Changes the behaviour of the webhooks associated with Wiki Page events to also be fired upon Wiki Page deletion. Currently, the webhooks for Wiki Page events are only fired upon creating and updating Wiki Pages.

Are there points in the code the reviewer needs to double check?

Please verify the changes to the WikiPage factory. WikiPages aren't models so the persistence of the resource differs.
Should the service be called DestroyService or DeleteService?
To squash or not to squash?