RSpec3

Upgrades rspec to 3.3.0, we're now up-to-date!

Added 27 commits:

• 3ad0f54d...e12b6431 - 16 commits from branch master
• c2b111d5 - Started on the actual rspec 3 upgrade
• e960f23e - Upgrade to newer version of Capybara
• 8a0a86d9 - Remove the "multiselect blob" features
• 21abef0d - Fix features syntax
• 65c64256 - Fix include_module matcher
• d8f0cead - Update and simplify Import controller specs
• 94d94e0b - Update mock and stub syntax for specs
• 490c0923 - Update email_spec gem
• 8463aa01 - Update spec/features/security specs
• cad2b0cc - Fix OAuth::User spec
• d29966a1 - Bump rspec to 3.3.0

Added 9 commits:

• 23c06d00 - Use to_reference for issue and merge request mentionable specs
• 8a346474 - Replace remaining references to Note.create_cross_reference_note
• f263470b - Fix GitPushService specs
• e0e480ef - Bump database_cleaner to ~> 1.4.0
• 00e343a8 - Bump pg gem to 0.18.2
• 374702cd - Move CapybaraHelpers to its own support file
• 26f321ea - Remove junk from db_cleaner spec support file
• 28e399d6 - Fix raise_error without an argument deprecation warnings
• 145b7c9a - Change to_not calls to not_to

Added 1 commit:

• 01de60f8 - Change to_not calls to not_to

Added 1 commit:

• b59e932c - Add sleep call before yield in allowing_for_delay

Title changed from WIP - RSpec3 to RSpec3

Added 32 commits:

• b59e932c...c0d9cbfd - 10 commits from branch master
• a07bb58c - Started on the actual rspec 3 upgrade
• 765e8254 - Upgrade to newer version of Capybara
• 061d8a9c - Remove the "multiselect blob" features
• 4647a80b - Fix features syntax
• a56493cc - Bump poltergeist to 1.6.0
• 8c482af6 - Fix include_module matcher
• 1db7da0c - Update and simplify Import controller specs
• daae4791 - Update mock and stub syntax for specs
• df7620a7 - Update email_spec gem
• b76be57a - Update spec/features/security specs
• 40995588 - Bump rspec to 3.3.0
• 3979b661 - Use to_reference for issue and merge request mentionable specs
• 47144bd7 - Replace remaining references to Note.create_cross_reference_note
• 1ee526e8 - Fix GitPushService specs
• 0316c917 - Bump database_cleaner to ~> 1.4.0
• d992a1c6 - Bump pg gem to 0.18.2
• 0cb75092 - Move CapybaraHelpers to its own support file
• 684657e9 - Remove junk from db_cleaner spec support file
• c1ff3332 - Fix raise_error without an argument deprecation warnings
• 706eaf4f - Change to_not calls to not_to
• 931a6ee3 - Add sleep call before yield in allowing_for_delay
• e36bbc60 - Fix Gitlab::OAuth::User spec

Added 25 commits:

• e36bbc60...74a6732c - 3 commits from branch master
• e76d4e94 - Started on the actual rspec 3 upgrade
• 08e182eb - Upgrade to newer version of Capybara
• abfc3cf7 - Remove the "multiselect blob" features
• 49d36cb4 - Fix features syntax
• 7963048a - Bump poltergeist to 1.6.0
• 12fbb6fa - Fix include_module matcher
• 53d8dafb - Update and simplify Import controller specs
• ed80410e - Update mock and stub syntax for specs
• 84e43b26 - Update email_spec gem
• 90baeeab - Update spec/features/security specs
• 32055143 - Bump rspec to 3.3.0
• 8e507d64 - Use to_reference for issue and merge request mentionable specs
• b8c9fee9 - Replace remaining references to Note.create_cross_reference_note
• daeba994 - Fix GitPushService specs
• cb3ee209 - Bump database_cleaner to ~> 1.4.0
• 68001960 - Bump pg gem to 0.18.2
• e401118e - Move CapybaraHelpers to its own support file
• 3d907709 - Remove junk from db_cleaner spec support file
• ba7c4e63 - Fix raise_error without an argument deprecation warnings
• 42f612fe - Change to_not calls to not_to
• 4070a238 - Add sleep call before yield in allowing_for_delay
• a20f92c5 - Fix Gitlab::OAuth::User spec

Added 24 commits:

• a20f92c5...6c0db429 - 2 commits from branch master
• 13dab37c - Started on the actual rspec 3 upgrade
• 3e8d0b99 - Upgrade to newer version of Capybara
• 0781f83d - Remove the "multiselect blob" features
• 3f690906 - Fix features syntax
• 7921b50d - Bump poltergeist to 1.6.0
• 6347662a - Fix include_module matcher
• b2d575f3 - Update and simplify Import controller specs
• 4ceabd5c - Update mock and stub syntax for specs
• 14982c28 - Update email_spec gem
• cfb6689a - Update spec/features/security specs
• 16fe0513 - Bump rspec to 3.3.0
• 77ebd355 - Use to_reference for issue and merge request mentionable specs
• e1f0223c - Replace remaining references to Note.create_cross_reference_note
• 8ed1d86b - Fix GitPushService spec
• 91bcf98b - Bump database_cleaner to ~> 1.4.0
• 5a78a141 - Bump pg gem to 0.18.2
• 03dbe641 - Move CapybaraHelpers to its own support file
• 7ba440c2 - Remove junk from db_cleaner spec support file
• 0688e0e5 - Fix raise_error without an argument deprecation warnings
• fca02ff1 - Change to_not calls to not_to
• 9fc56382 - Add sleep call before yield in allowing_for_delay
• 458b711a - Fix Gitlab::OAuth::User spec

Reassigned to @dzaporozhets

@dzaporozhets The big'un. It's ready.

Added 72 commits:

• 458b711a...75f7a964 - 51 commits from branch master
• f3d99a1e - Started on the actual rspec 3 upgrade
• d6cd2e6a - Upgrade to newer version of Capybara
• afec5efc - Fix features syntax
• 990ddeba - Bump poltergeist to 1.6.0
• 9874cf59 - Fix include_module matcher
• dad88568 - Update and simplify Import controller specs
• 5a9ede47 - Update mock and stub syntax for specs
• 20a871cc - Update email_spec gem
• 1f7490a2 - Update spec/features/security specs
• 15133d99 - Bump rspec to 3.3.0
• 213d1a47 - Use to_reference for issue and merge request mentionable specs
• 2120e2dd - Replace remaining references to Note.create_cross_reference_note
• 7460c39f - Fix GitPushService spec
• 018fcc59 - Bump database_cleaner to ~> 1.4.0
• ef206b79 - Bump pg gem to 0.18.2
• da135119 - Move CapybaraHelpers to its own support file
• 8b1f1ab3 - Remove junk from db_cleaner spec support file
• 0f627f1c - Fix raise_error without an argument deprecation warnings
• bf71d53f - Change to_not calls to not_to
• 1dd42da8 - Add sleep call before yield in allowing_for_delay
• e4e01dbf - Fix Gitlab::OAuth::User spec

@rspeicher it was not mergeable so I rebased on master. Lets see it tests green and I will merge

Status changed to merged

mentioned in commit 595b3323

Yay