About GitLab link in sidebar that links to help page

Closes #24479 (closed)

Corresponding EE change: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1008

@tauriedavis + @awhildy : Can you take a look? Thanks.

Thanks @victorwu!!

A couple questions:

1. Is this only for CE? Would we need to do something separate to make sure it is right for EE?
2. Nitpick - when you resize the window short, it overlaps the left nav. Probably not a huge concern as having a browser window that short isn't common, and any fix probably is overcomplicated. But thought I'd mention it in case there is an easy fix. 😉

1. I assume that the same code would need to be replicated in the EE source to get it to say About GitLab EE. I looked at the help page and at least that is one location where there isn't special code to differentiate CE vs EE. It's just hardcoded in. https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/help/index.html.haml. So I assume we should take the same approach here. Whenever this is code-reviewed, the reviewer / developer can comment on that.

2. Yep. I don't think that needs to be a concern, even with mobile, as it would be unlikely to have a resolution and device that would incur that overlap. But we can mention it during code review if it's a problem.

@jschatz1 : Could you review this feature and code?

assigned to @jschatz1

removed assignee

@smcgivern : Jacob might be away. Would you be able to review this or get someone to? Thanks!

My understanding is that there is nothing in place currently to change something in EE that is hardcoded in CE. EE only adds to what is in CE (at least that was my understanding about another issue I worked on). So there would need to be something in place that changes the text dynamically...

It looks like I was wrong! I see what you are saying about the help being hard coded. Seems weird to me but I guess if we do that there already then it makes sense...

@victorwu LGTM! Can you please create an EE MR?

added 154 commits

• d92ac95b...19e3ab18 - 153 commits from branch master
• 4815314b - About GitLab link in sidebar that links to help page

Compare with previous version

assigned to @smcgivern

Thanks @smcgivern . The equivalent EE one is here: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1008

mentioned in commit 27db8f72

merged

Thanks @victorwu! 🔖

changed milestone to %8.16