Fixes the incoherent filtering by milestone in `/projects/:id/issues` and `/groups/:id/issues` endpoints
Originally opened at !7134 (closed) by @eisnerd.
Changing /projects/:id/issues
and /issues
to use the IssuesFinder changes the meaning of the labels parameter, so the tests have been changed to match. This could be a slight gotcha for existing API users. The resources gain some parameters that are implemented in the IssuesFinder
but not documented in the API documentation or covered by the API tests. These could become part of the API simply by adding docs and tests, but this has not been done in this MR.
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
Closes #23194 (closed)
Merge request reports
Activity
assigned to @rymai
mentioned in merge request !7134 (closed)
- Resolved by username-removed-443319
- Resolved by username-removed-128633
- Resolved by username-removed-128633
- Resolved by username-removed-128633
@rymai see above, some of these might be resolved by the rebase!
added 1283 commits
-
84f04372...91e56012 - 1281 commits from branch
master
- 4433b9f1 - Adding 'IssueFinder' for 'projects' API endpoint
- b8083fe4 - API: Implement project issues iid param with IssuesFinder and add tests
-
84f04372...91e56012 - 1281 commits from branch
added 1 commit
- fd1d903f - API: Implement project issues iid param with IssuesFinder and add tests
Thanks @smcgivern, I've addressed your feedback!
assigned to @smcgivern
added 1 commit
- fd1d903f - API: Implement project issues iid param with IssuesFinder and add tests
- Resolved by username-removed-128633
assigned to @rymai
added 1 commit
- 9cc61bce - API: Implement project issues iid param with IssuesFinder and add tests
mentioned in merge request !8455 (closed)
assigned to @smcgivern