Skip to content
Snippets Groups Projects

Fixes the incoherent filtering by milestone in `/projects/:id/issues` and `/groups/:id/issues` endpoints

Originally opened at !7134 (closed) by @eisnerd.


Changing /projects/:id/issues and /issues to use the IssuesFinder changes the meaning of the labels parameter, so the tests have been changed to match. This could be a slight gotcha for existing API users. The resources gain some parameters that are implemented in the IssuesFinder but not documented in the API documentation or covered by the API tests. These could become part of the API simply by adding docs and tests, but this has not been done in this MR.

Does this MR meet the acceptance criteria?

Closes #23194 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @rymai see above, some of these might be resolved by the rebase!

  • added 1283 commits

    • 84f04372...91e56012 - 1281 commits from branch master
    • 4433b9f1 - Adding 'IssueFinder' for 'projects' API endpoint
    • b8083fe4 - API: Implement project issues iid param with IssuesFinder and add tests

    Compare with previous version

  • added 1 commit

    • fd1d903f - API: Implement project issues iid param with IssuesFinder and add tests

    Compare with previous version

  • Thanks @smcgivern, I've addressed your feedback!

  • added 1 commit

    • fd1d903f - API: Implement project issues iid param with IssuesFinder and add tests

    Compare with previous version

  • added 1 commit

    • 9cc61bce - API: Implement project issues iid param with IssuesFinder and add tests

    Compare with previous version

  • mentioned in merge request !8455 (closed)

  • Ok we're good now!

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading