Strip reference prefixes on branch creation
requested to merge c0riolis/gitlab-ce:26470-branch-names-with-reference-prefixes-results-in-buggy-branches into master
What does this MR do?
Strip special prefixes ("refs/heads/" and "refs/remotes/") at the beginning of CreateBranchService.execute.
Why was this MR needed?
Forwarding branch names as-is to the backend was causing buggy branches and thus various crashes.
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #26470 (closed)