Skip to content

don’t count tasks that are not defined as list items correctly

Jarka Kadlecova requested to merge jarka/gitlab-ce:26068_tasklist_issue into master

What does this MR do?

It fixes a problem with tasks counts: Tasks that are not formatted as list items are not considered as tasks (task_list gem requires that tasks are always in a list) however on our side we count these "not tasks" as tasks.

Reason

The regex that was used on our side is the same regex that is used in the task_list gem. However in that gem html string is being matched on the other hand in taskable.rb on our side we match simple text not the html version.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

bug reported in #26068 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

fixes #26068 (closed)

Merge request reports