Update ffaker to ~>2.4 to avoid generating names with suffixes (!8596) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

username-removed-128633 requested to merge 26492-fix-transient-failure-in-commits_spec into master Jan 16, 2017

What does this MR do?

FFaker 2.4 doesn't include suffixes when FFaker::Name.name is used, thus this will prevent issues such as #26492 (closed) from happening.

FFaker 2.0: https://github.com/ffaker/ffaker/blob/v2.0.0/lib/ffaker/name.rb#L14
FFaker 2.4: https://github.com/ffaker/ffaker/blob/v2.4.0/lib/ffaker/name.rb#L16

Closes #26492 (closed)