Paginate all the things
What does this MR do?
It paginates all endpoints which return an array but do not use pagination
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/8099, https://gitlab.com/gitlab-org/gitlab-ce/issues/1746, https://gitlab.com/gitlab-org/gitlab-ce/issues/20236, https://gitlab.com/gitlab-org/gitlab-ce/issues/20248, https://gitlab.com/gitlab-org/gitlab-ce/issues/23302, https://gitlab.com/gitlab-org/gitlab-ce/issues/14791, #27306 (closed)
Merge request reports
Activity
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-2900
added 369 commits
- 63c3ba7a - Created shared/visibility_select and merged with feature permissions ui
- 26b0fe8d - Align permissions options
- 2c9bb135 - Fixed tests
- afea2df1 - First attempt
- a6ab8a34 - Add BuildQueueWorker for injecting redis-keys
- 0d438156 - This is needed as well...
- aa224c13 - typo-o
- 692426b1 - Use correct variables
- 771dd68c - linting
- e1795443 - Move redis-logic into Ci::Runner
- a20681c0 - Update Runners in a Service
- 811addf2 - #NamingThings
- 94b2df02 - Make ensure_runner_queue_value atomic
- f6263e2e - Don't use redis.multi
- 24f0a45b - Do things in the correct order
- fb713071 - Use Token instead of ID
- b0b05f81 - Make expire-time a constant, correct function in Service
- 74a48ecd - Change name of expire constant
- f14228f0 - Notify the user who set auto-merge when a build fails
- f35336a1 - Fixed broken build
- 2c9ee1bb - Add documentation for possible causes of JS-related test failures.
- ec5c12ce - Fix markdown errors.
- b46ad4c9 - Fix Slash command templates
- 932bcb4d - Added isAuthenticate to differentiate between ineligible messages
- 8c9a4ed3 - WIP: Add tests and make sure that headers are set
- df99883d - Add tests for admin service templates
- fa8052a4 - Do not show artifacts keep button if not allowed
- 4a7e1423 - Add changelog for artifacts button visibility fix
- 5456859b - Add method that checks for expiring build artifacts
- b11492c2 - Use cached values to compute total issues count in milestone index pages
- 5dc8fe31 - Fix Compare page throws 500 error when any branch/reference is not selected
- 6972a35f - Added specs for branches compare when from & to are empty
- 8b30dd98 - Extract abstract success with warnings CI/CD status
- 8dbd1e7d - Add concrete success warning status to stage factory
- fd115bc1 - Add specs for two new methods defined in stage class
- e5d53df7 - Add changelog for warning icon for stage in graph
- 9f127918 - Add extended status for build failed but allowed to
-
7ab3dd4b - support
/merge
slash comand for MRs - aa934c74 - refresh merge widget after using /merge command
- e1302007 - Merge branch 'master' into i-#25814-500-error
- 1d01ffb7 - Make it possible to combine extended CI/CD statuses
- 48c19e73 - Expose methods that match statuses in status factories
- 6053049f - Add new CI/CD status failed with warnings icon group
- 227cbdd8 - Use detailed status for failed but allowed builds
- 528c0688 - Fix a Rubocop offense in detailed status factory
- ee18d89f - Extend pipeline detailed status factory specs
- ca0cf5a3 - Show 'too many changes' message for merge request
- cb316804 - Add hover state to MR comment reply button
- 047107a4 - Add margin to math blocks
- 2f0bbd3d - Adds .catch to the request in order to handle erros and show a feedback to the user
- 463fddea - Adds tests
- ec1556ca - Merge branch 'master' into i-#25814-500-error
- d92f1aba - Fixed some HAML errors on milestone#show
- 557a0bf1 - Address MR comments
- 683ea89e - Use bootstrap dropdown events to only make the request when the dropdown is being opened
-
66ccf2d9 - Document the
auto_link_ldap_user
setting - 85e0b994 - Notify the user who set auto-merge when merge conflict occurs
- c2283a2d - Changed alert message character: from & to and
- 241e2e87 - Merge branch 'master' into i-#25814-500-error
- 0413a7ad - from or to get variables gets preserved if the other one is missing
- 87c39b6d - Added specs for the preservation of the from/to parameter
- b038c530 - Move default values to ApplicationSetting::DEFAULTS and use it in CurrentSettings
- f6cc29ed - Don't persist ApplicationSetting in test env
- 64dd41a0 - Backport timetracking frontend to CE.
- 17196a2f - Backport backend work for time tracking.
- 770a199f - Prevent including Vue twice
- b5ab18c6 - Bring changes that were present only in EE.
- b55d2d65 - Slight modification to the doc
- 09a61416 - Fix haml-lint complain.
- 63b36241 - Fix scss variable refs.
- 4657c287 - Merge branch 'master' into fix/keep-artifacts-button-visibility
- cf3be218 - Speed up dashboard milestone index by scoping IssuesFinder to user authorized projects
- 725b1654 - Filter environments visibility in store instead of the view in order to not get …
- 9844c1f2 - Refactored ‘from’ and ‘to’ variable preservation
- fe4c2b8b - Merge branch 'master' into i-#25814-500-error
- db0f9ef4 - Make cycle_analytics_events_spec.rb side-effect free
- 3f581e8d - Correctly keeps merge request tabs in place when editting value in
- 856003cf - refactor rubocop suggestion
- 1b1bccdb - Fixes big pipeline and small pipeline width problems
-
959f65a0 - Correct documentation for
data_attribute
method - 90ee81dc - Document GIT_SUBMODULE_STRATEGY
- d5e996d1 - Switch to sassc-rails
- 632d22ac - Mark Commit persisted
- eb61d493 - Autoresize markdown preview
- 2ac01785 - Remove some useless require_relative statements
- e7fdb1aa - Merge branch 'switch-to-sassc' into 'master'
- 3268e377 - WIP - started refactoring cycle analytics median stuff into stages
- a9982762 - added analytics stage serializer and moved some info to the stage classes from the controller
- dc6ea14b - fixed stage entity and added missing stage specs
- fc6f8f20 - added new summary serializers and refactor all of the summary stuff into separate logical classes
- 8639ea1b - fix bad merge
- 02e1e481 - more refactoring and fixing old specs
- a67311cb - Fix other spec failures
- e4e313fc - Fix other spec failures
- 8183e848 - fix tricky test failure to do with private method
- b8056669 - refactor cycle analytics - updated based on MR feedback
- 69ecd951 - refactor fetcher and fixed specs
- 58dddcdf - few fixes after merge
- daa4f3de - fix spec failures after merge
- b214be49 - big refactor based on MR feedback
- 3f681f4c - fix specs, refactor missing bits from events stuff
- 099aa124 - fix plan stage issue and some spec failures
- 056b0f19 - fix missing refactor in metrics fetcher
- bbb9f840 - a few more fixes
- 834bcacb - fix refactor of production event fetcher
- 982d5a05 - refactored metrics fetcher - merged into stage and events
- 30c6703f - fix specs
- 1b220df5 - fix bug retrieving medians
- 34875ce6 - fix serializer
- 150a4485 - refactored a bunch of stuff based on feedback
- 1d775d97 - fix spec
- 476fce4e - Disable all cops in .rubocop_todo.yml
- 2d6d52ca - Improve pipeline specs by removing instance variables
- 8faf0c7a - Add detailed statuses for external commit statuses
- 9f1beed7 - Link external commit status badge to a target URL
- b222f6d5 - Fix EmptyLines Rubocop offense in pipeline specs
- 32ab86d4 - Add specs for a new external build detailed status
- 92682b8a - Shows current user on top of filtered dropdown list
- cfdae8f1 - Merge branch 'pmq20/gitlab-ce-psvr/persisted' into 'master'
- e324ccc2 - Merge branch 'issue_25017' into 'master'
- fbc1a06c - Merge branch 'fix/keep-artifacts-button-visibility' into 'master'
- 16b1512e - Merge branch 'reduce-queries-milestone-index' into 'master'
- 25709853 - Merge branch '24915_merge_slash_command' into 'master'
- ea988d97 - Merge branch 'rubocop-todo' into 'master'
- 65046d9a - Merge branch 'mr-tabs-alignment-sidebar-open' into 'master'
- 9c560b5c - Replace many :project with :empty_projects in API specs
- 4fb4f615 - better UI fix - simple solution
- 2e088c06 - Add Changelog entry for external status link fix
- e2f0b830 - Merge branch '26756-fix-already-intialized-constant-warnings' into 'master'
- 28e77da9 - Merge branch 'master' into ui_pipelines_mini_graph
- 96b7865b - fix UI behaviour - only make new calls when button is clicked and dropdown is not displayed
- 97610fda - get rid of log
- a5c7097c - Fix search bar filter dropdown scrollbars
- b6c7e88d - Update clipboard_button text: Copy commit SHA to clipboard
-
a8b4ab9d - Add a
:repository
trait to the:empty_project
factory -
822bf2f9 - Add the
:repository
trait to:project
factories in Cucumber steps - 8fac013d - Remove repository trait from factories that don't need it in features
- 4bb3675b - Fix Project#update_repository_size to convert MB to Bytes properly
- cff9c16b - Pass memoizable warnings attribute to stage object
- e66b0414 - Improve readability of specs for pipeline stages
- 3bc0525a - Extract compound statuses method in status factory
- 73fcfb29 - Add a default status const to common status concern
- f5ff5dc2 - Merge branch 'clipboard-button-commit-sha' into 'master'
- cdf0af66 - Merge branch 'i-#25814-500-error' into 'master'
- 53f4f849 - Add URL validations for generic commit statuses
- 9ce8aa31 - Respond with validation errors in commit status API
- c79e12b5 - Fixing typo
- ac322d38 - Fixed highlightFirst and added specs
- 3ac6054b - correct User_agent placement in robots.txt
- 35442766 - do not map usersat all unless admin
- 5e9196b3 - Merge branch 'patch-12' into 'master'
- 2d2fe2cf - Add first shared examples to a helper and updated teaspoon_env to allow helper specs to run
- 8f427208 - add changelog yml file
- f7eb3573 - Ensure group acts as a namespace for polymorphic routes
- b3bb8dc4 - added spec replicating the problem
- d143cae9 - Merge branch 'master' into ui_pipelines_mini_graph
- b4f67cc2 - Document presenters
- fd72c0f4 - Handle presenters in BasePolicy
- bf789ff5 - Improve presenter architecture
- e5a29b45 - Improve presenter factory
- 78874519 - Add Presentable concern
- e950830b - Fix typos and improve presenters documentation
- 061bb6eb - More improvements to presenters
- f208897c - Merge branch 'backport-time-tracking-ce' into 'master'
- 6a57e93f - Merge branch 'master' into ui_pipelines_mini_graph
- e6753362 - use destructuring syntax instead
- 52e652cb - Merge branch 'rs-data_attribute-cleanup' into 'master'
- 7c7b2041 - Merge branch '26773-fix-project-statistics-repository-size' into 'master'
- 17c09916 - fix and refactor note user mapping
- 0f3c9355 - Add some API endpoints for time tracking.
-
bbd71328 - Replaced
.pull-right
with.right
- 504bdaf3 - Upgrade Brakeman to 3.4.1
- c7390058 - Merge branch 'rs-repository-project-trait' into 'master'
- 0a1c8bb3 - Pass Gitaly resource path to gitlab-workhorse if Gitaly is enabled
- cc1e43da - Merge branch 'time-tracking-api' into 'master'
- 1cc6d206 - Merge branch 'fix/refactor-cycle-analytics-stages' into 'master'
- 6b0ea00d - Merge branch 'correct_robots_txt' into 'master'
- 61b6643e - Merge branch 'ui_pipelines_mini_graph' into 'master'
- 9f0d7945 - Moved the webhooks and services gear options to a single one called integrations
- 1ee4f986 - Fixed spinach feature tests for the services and hooks controllers
- bc7c6c68 - Fixed more tests
- 373411d1 - Corrected code style and titles
- 0af99433 - Removed the index action from both the projects hook and services controllers
- 7b3ea49a - Fixed tests and a rubocop linter
- 6359a3fc - Fix small button alignment issues
- 154ac0c4 - Merge branch '26667-pipeline-width-for-huge-pipeline' into 'master'
- 270dc226 - Merge branch '26777-scrollbar-in-searchbar-autocomplete-dropdown' into 'master'
- 9e4d0491 - resolve all no-plusplus eslint violations
- e7b5945c - resolve all semi and no-extra-semi eslint violations
- ccada28f - resolve all padded-blocks eslint violations
- bf638d68 - resolve all no-irregular-whitespace eslint violations
- b857b21f - resolve all no-trailing-spaces eslint violations
- 96931b17 - resolve all indent eslint violations
- 04eff5fd - resolve all x-spacing and no-spaced-x eslint violations
- 588d7e8a - resolve all parseInt radix eslint violations
- 0b3f0049 - resolve all no-dupe-keys eslint violations
- 83ecc02d - resolve all prefer-const eslint violations
- d55d4cdf - resolve all space-in-parens eslint violations
- 9ba288dd - add missing changelog
- 63e8dc8a - Add documentation around OAuth/Personal Access Token scopes.
- e8a9682b - fix typo
- 2dd5db74 - Add sorting pipeline for a commit
- 56512cc1 - Merge branch 'current-user-filter-top' into 'master'
- 07f59a5a - Add Slack slash commands to project services list index
- 9e485500 - Merge branch 'docs/add_slack_to_services_list' into 'master'
- 2a0d6342 - Merge branch 'speed-up-dashboard-milestone-index' into 'master'
- d3f26be6 - Merge branch '23524-notify-automerge-user-of-failed-build' into 'master'
- e59623e7 - Mark MR as WIP when pushing WIP commits
- ea7bf7ed - Show a custom WIP help message for MR's with WIP commits
- b71b0acd - Merge branch 'zj-fix-admin-templates' into 'master'
- 046e0bd6 - Merge branch 'fix/external-status-badge-links' into 'master'
- fd1e4c75 - Merge branch '26117-sort-pipeline-for-commit' into 'master'
- 5ba18c58 - Merge branch 'document-auto_link_ldap_user' into 'master'
- 97475d0b - Merge branch '24032-changed-visibility-level-to-public-but-project-is-not-public' into 'master'
- a2a43d82 - Merge branch 'input-button-hover' into 'master'
- f9964794 - Merge branch '26803-typing-then-tab-in-a-comment-doesn-t-select-the-author' into 'master'
- 95f0d985 - Merge branch 'milestone-issuable-row-numbers' into 'master'
- c3bea33c - Merge branch 'patch-9' into 'master'
- 8171a193 - Merge remote-tracking branch 'origin/master' into 21698-redis-runner-last-build
- 9a985f6e - Merge branch '23563-document-presenters' into 'master'
- fb347f90 - Revert "Merge branch 'switch-to-sassc' into 'master'"
- 0ece506e - Merge branch 'rs-revert-sassc' into 'master'
- 4f1eb8cd - Fix todos spec
- b67a1b60 - Merge branch 'wip-mr-from-commits' into 'master'
- 1c7eb963 - Add missing build_spec
- 4616617d - Merge branch 'simple-eslint-fixes' into 'master'
- 52762df2 - Merge branch 'brakeman-upgrade' into 'master'
- aab60054 - Merge branch 'allow-shared-examples-jasmine' into 'master'
- 639b880e - Merge branch 'button-alignment' into 'master'
- c84272dc - Merge branch 'feature/gitaly-feature-flag' into 'master'
- e8e2a6a9 - Merge branch 'didemacet-markdown-area-height-fix' into 'master'
- 621b23da - Add an image to the public access documentation and fix wrong profile path
- 86217866 - Fix warnings argument memoization in CI/CD stage
- 2de5f511 - Merge branch 'fix-dashboard-spec' into 'master'
- 4b999ccd - Merge branch '26810-fix-undefined-method-revert_group_project_commit_path' into 'master'
- f1568d71 - Merge branch 'use-empty_project-factory-in-api-specs' into 'master'
- bb56a1fe - Merge branch '26472-math-margin' into 'master'
- 1c81452a - Merge branch '26601-dropdown-makes-request-close' into 'master'
- 5db587a1 - Responsive title in diffs inline, side by side, with and without sidebar
- 815c0910 - Adds tooltips
- 28b4407b - Fix haml linter errors
- 2bb2544e - Use flexbox instead of media queries
- 1446a03e - Remove fixed class from file actions
- 6669bfd3 - Merge branch '25507-handle-errors-environment-list' into 'master'
- d7318a56 - Merge branch 'improve-public_access-documentation' into 'master'
- 4bf97250 - Merge branch '26066-wrong-messsage-for-unregistered-u2f-device-on-sign-in' into 'master'
- 2bf5fe5e - Rename duplicate migrations and skip them if table/columns are already present
-
d9f53a35 - Convert most Project model specs to use
:empty_project
- 2c72e0e7 - Fix participants margins to fit on one line
-
1502d564 - Convert most User model specs to use
:empty_project
-
7e6ff8ca - Convert most MergeRequest model specs to use
:empty_project
- 8f391fd3 - Renamed a file to make the transition to EE easier
-
a3d8c0b2 - Convert MoveToProjectFinder specs to use
:empty_project
- 31af6be0 - Fix specs
- e6875cb0 - Merge remote-tracking branch 'origin/master' into 21698-redis-runner-last-build
- a5afcf0f - Added CHANGELOG
- d8e440c8 - Fix specs
- 0eef032d - Merge branch '26868-fix-duplicate-backported-migrations' into 'master'
- cf1f7e89 - Merge branch 'ci-submodule-doc-update' into 'master'
- 746e7e76 - Fix specs
- 1bb0191a - Make university more prominent.
- 0db574aa - keep graph displayed when build is clicked so that multiple tabs can be opened from graph
- e5e3a9a3 - handle actions and builds
- bab8af9b - remove need for spinner on additional clicks - visual diff is actually very nice
- 5a41d92b - Merge branch '21698-redis-runner-last-build' into 'master'
- 3f17f29a - Added current user filter to assignee dropdown
- 34ef6ce3 - Merge branch '26138-combine-webhooks-and-services-settings-pages' into 'master'
- 491f1375 - Merge branch 'rs-empty_project' into 'master'
- 26d109ea - Remove prefilled prefix
- 607b3c48 - Fix Slack/Mattermost notifaction services
- 8c41d5f5 - Record used SSH keys only once per day
- 1f314195 - Do not generate pipeline ref path if ref not present
- 36afc974 - Add Changelog entry for pipeline ref path error fix
- c74f0401 - Use Workhorse v1.3.0
- 4b7e8f25 - Merge branch '25851-document-token-scopes' into 'master'
- 10678525 - Fix shared runners queue update
- ecb9f978 - Improve readability of runner tick queue method
- a5ab418c - Add missing specs for update build queue service
- 71472968 - Merge branch 'workhorse-v1.3.0' into 'master'
- e8396d8e - fix member mapper spec
- 029b9019 - Merge branch 'record-used-ssh-keys-once-per-day' into 'master'
- 9cac0317 - Merge branch 'dont-persist-application-settings-in-test-env' into 'master'
- 4af1f186 - Merge branch 'fix/import-users' into 'master'
- f90685b8 - remove bitwise - make code human readable
- d8690a05 - Merge branch 'participants-list' into 'master'
- ff75bd04 - Merge branch 'fix-shared-runners-queue-update' into 'master'
- df3db8e8 - Merge branch 'master' into keep_mini_graph_down_pipelines_index
- 2c6471dd - Changed the event listener target from window to document in droplab
- aaa986c0 - Don't define ApplicationSetting defaults in a constant
- d2855e34 - remove 2gb tag from ci
- a91ff32b - Merge branch '25709-diff-file-overflow' into 'master'
- 41b6cfcf - automatically redirect urls containing author_id or assignee_id
- b16dad7b - Merge branch 'keep_mini_graph_down_pipelines_index' into 'master'
- 7b9aa79d - pass username and id associations needed in the frontend
- 948c3e4e - Merge branch 'ah-remove-2gb-tag' into 'master'
- a20fbcaa - Fixed search component not instantiating back when pressing the back button on the issue page
- d6529dbb - Merge branch 'backport-fix-load-error' into 'master'
- 8dbac708 - Revert "Merge branch 'backport-fix-load-error' into 'master'"
- 2f72d590 - Merge branch 'revert-d6529dbb' into 'master'
- 3975ee57 - Merge branch 'filter-assigned-to-me' into 'master'
- 5c6a7aae - Merge branch '26617-search-bar-filter-dropdown-does-not-dismiss-when-sort-dropdo…
- e0d248f9 - Merge branch '26955-handle-legacy-issue-filter-params' into 'master'
- c0a9ece1 - Fix DropLab in IE11 v1
- 71de0efb - Merge branch '26623-search-bar-dropdown-doesn-t-load-when-you-go-back-in-browser…
- 611917ec - Merge branch '26785-fix-droplab-in-ie-11-v1' into 'master'
- f19724de - Revert "Merge branch '26785-fix-droplab-in-ie-11-v1' into 'master'"
- bb6f931b - Merge branch 'revert-611917ec' into 'master'
- 6fe2adda - Merge branch 'fix/pipeline-ref-path-serialization' into 'master'
- e447ea63 - Add index for ci_builds that makes shared runners query to run 50x faster.
- 86881f4f - Add index for ci_runners if they are shared
- 1fce08f9 - Merge branch 'add-index-on-ci-builds' into 'master'
- 85a3c03c - Revert "Merge branch '25709-diff-file-overflow' into 'master'"
- 0ef587b6 - Merge branch 'revert-a91ff32b' into 'master'
- 79659b30 - Filtered search input click back at token
- ac080c63 - Opens dropdown correctly
- c45dc802 - Correctly replaces string when selecting in dropdown
- 658c6c26 - Fixed filter issue
- 91ad8c3c - Trigger filter on click
- 88b4ea60 - Teaspoon test fix
- ab1b8d50 - Added tests
- a4789db9 - Fixed bug replacing full input value
- 80c0b877 - Fixed issue when label or milestone had space
- 1980403c - Fixed caret not moving correctly
- eb993dc5 - Fixed bug with hint not showing when in middle of text
- 4a797620 - Added comments to regex
- 8198d498 - Places dropdown at cursor position
- 317ef7b5 - Fixed failing JS specs
- e75c20fc - Fixed issue with multiple words not filtering correctly
- 1b63b3fe - Fix DropLab in IE11 v1
- b97fd7fa - Add event delegation to prevent events from not firing in certain states.
- 62cb179e - Load ci_bundle javascripts in MWBS partial
- afd6bcb9 - Extend feature tests for merge when pipeline succeeds
- d50b64dc - Add Changelog for MWPS immediate merge bug
- e8552366 - Merge branch '26785-fix-droplab-in-ie-11-v1' into 'master'
- bddd09c4 - Merge branch 'issue-search-token-position' into 'master'
- f6f52b43 - Merge branch 'fix_auto_merging' into 'master'
- 98dbb8e2 - Introduced an offset limit to prevent the dropdown from going far right
- baeaa97e - Revert "Merge branch 'dont-persist-application-settings-in-test-env' into 'master'"
- 4b7ec44b - Merge branch '26618-search-bar-dropdown-offset-should-not-go-past-search-bar-input' into 'master'
- c2093486 - Merge branch 'revert-9cac0317' into 'master'
- 31da4b07 - Button by itself will submit forms. Button type button willn't
- 0363734c - Merge branch 'fix-upload-group-avatar' into 'master'
- 5c444aed - Update autodeploy templates [ci skip]
- 125abfd4 - Merge branch 'update-auto-deploy-templates' into 'master'
- 1b3b4f4e - Fixed bug with merge immediately button would not work
- 91608be8 - Added spec tests
- 606147c3 - Replace merge request widget body
- 243b18c7 - Add Prometheus docs
- 73375c18 - Expose Prometheus docs to the main README
- a92c0f9c - Use archived trait for project in specs instead model column
- 0630f672 - Merge branch 'merge-dropdown-this-context' into 'master'
- 43f0fd1f - Add information on the dashboard and exporter ports
- 8ff3db13 - Merge branch 'docs/prometheus' into 'master'
- db930696 - Merge branch 'mr-widget-replace-body' into 'master'
- 22f69a4f - Merge request widget class names update
- 64ef0d8c - Update CHANGELOG.md for 8.16.0
- 084ac867 - Update VERSION to 8.17.0-pre
- 352ea0ae - Merge branch 'mr-widget-reload-fix' into 'master'
- 03206a87 - Fix the most important part of the readme
- 52a7112f - Merge branch '26622-fix-transient-failure-in-cycle_analytics_events_spec' into 'master'
- 184ba52f - correct the prometheus feature configuration according to https://gitlab.com/git…
- fca41b41 - Add hover style for copy icon in commit page header
- 8a6e4152 - Merge branch 'patch-12' into 'master'
- 3a54128d - Merge branch 'zj-mattermost-fixes' into 'master'
- 3ac224e6 - Merge branch 'use-archived-trait' into 'master'
- 1a8647f5 - Merge branch 'fix-readme' into 'master'
- 7446c2f5 - Merge branch 'feature/success-warning-icons-in-stages-builds' into 'master'
- 6c65f7a7 - Merge branch '26787-add-copy-icon-hover-state' into 'master'
- 6b61221e - Paginate all endpoints that return an array
Toggle commit list@rymai I fixed the issues. Can you look again?
@razer6 LGTM but we should add specs to assert that these endpoints are now paginated?
assigned to @razer6
@rymai I also thought about that. What about checking if pagination headers are available?
What about checking if pagination headers are available?
@razer6 Yep, that should do it!
@rymai Is a simple
expect(response.header).to include('X-Total')
or should we aim to check all headers? Especially, because thecommit_status
API uses a non-compliant custom pagination right now.If so, we could add a custom matcher for pagination headers.
@razer6 I think there is already one?
mentioned in issue #27306 (closed)
changed milestone to %8.17
added 932 commits
-
bdcecf6d...178626ed - 912 commits from branch
master
- 62137399 - Remove /projects/:id/keys/.. endpoints
- a2c298fa - Update CHANGELOG.md for 8.16.4
- 7f514c70 - layout rearranged
- cb1b7692 - hides search button
- c35bddea - adds changelog
- 011569a8 - fixes mobile view
- d8f2a812 - Make all system notes lowercase
- f39072e8 - Remove noteable object in time tracking system notes [ci-skip]
- 14960157 - Update system_note_service_spec.rb
- e29bb9ff - Add changelog file
- 1a70167b - Remove deprecated MR and Issue endpoints and preserve V3 namespace
- c8f869a6 - Remove hover animation from row elements
- 94ad89c8 - removed commented out scss
- 49fbfebf - Removed additional dropdown list animations
- fbe45a5d - Don't render snippet actions for logged-out users
- f52e074f - Added specs for merge request environment list
- af2fc5de - Map configuration to directory locations and add defaults to NFS HA doc.
- 1c493e60 - Paginate all endpoints that return an array
- d01f7a24 - Add a custom pagination matcher
- 464cf337 - Backport API to v3
Toggle commit list-
bdcecf6d...178626ed - 912 commits from branch
added 30 commits
-
464cf337...7c8033e0 - 26 commits from branch
master
- 16cf1aa8 - Remove /projects/:id/keys/.. endpoints
- 976534dd - Paginate all endpoints that return an array
- 866b0965 - Add a custom pagination matcher
- 44abe4a7 - Backport API to v3
Toggle commit list-
464cf337...7c8033e0 - 26 commits from branch
added 347 commits
-
990a718b...06092b75 - 344 commits from branch
master
- 83e19939 - Paginate all endpoints that return an array
- be50e871 - Add a custom pagination matcher
- 803fcc50 - Backport API to v3
Toggle commit list-
990a718b...06092b75 - 344 commits from branch
added 93 commits
-
be3a5758...bbb7fbcd - 90 commits from branch
master
- 0d6304e1 - Paginate all endpoints that return an array
- e6080da6 - Add a custom pagination matcher
- 67529070 - Backport API to v3
Toggle commit list-
be3a5758...bbb7fbcd - 90 commits from branch
added 2 commits
assigned to @rymai
@rymai Could you do a review?
mentioned in issue #19311 (closed)
@rymai Friendly reminder, or is @smcgivern reviewing the the API changes?
@rymai can take it
changed milestone to %9.0
@razer6 Sorry, this has been on my radar for a few days now, I will get to it!
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-128633
@razer6 Nice! I had a few remarks, and that'll be good. Sorry for the wait!
assigned to @razer6
added 411 commits
-
8584878f...f802ad37 - 408 commits from branch
master
- ec0239dd - Paginate all endpoints that return an array
- 8acf64de - Add a custom pagination matcher
- 11ebb0f4 - Backport API to v3
Toggle commit list-
8584878f...f802ad37 - 408 commits from branch
added 163 commits
-
11ebb0f4...28d8b865 - 160 commits from branch
master
- 01ea65e0 - Paginate all endpoints that return an array
- c70dfbc6 - Add a custom pagination matcher
- 60812e24 - Backport API to v3
Toggle commit list-
11ebb0f4...28d8b865 - 160 commits from branch
assigned to @rymai
@junalmeida I recall there is an open merge request for that!
I was thinking about https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6078/diffs
mentioned in issue #35257 (moved)
mentioned in issue janslow/gitlab-fetch#3