Add performance/scalability concerns to CONTRIBUTING.md (!8677) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Stan Hu requested to merge sh-expand-on-definition-of-done into master 8 years ago

1 unresolved thread

Activity

Stan Hu @stanhu · 8 years ago

Author Maintainer

@jschatz1 @DouweM @smcgivern @yorickpeterse @pcarranza Thoughts on this change?
username-removed-274314 @pcarranza · 8 years ago

Maintainer

I would add n+1 queries or repeated filesystem access.
username-removed-274314 @pcarranza · 8 years ago

Maintainer

Besides that. LGTM
yorickpeterse-staging @yorickpeterse · 8 years ago

Maintainer

Besides what @pcarranza mentioned this looks good to me.
Jacob Schatz @jschatz1 started a thread on an old version of the diff 8 years ago

CONTRIBUTING.md

 . Contains functionality we think other users will benefit from too
 . Doesn't add configuration options or settings options since they complicate
    making and testing future changes
 . Changes do not adversely degrade performance (e.g. avoid repeated polling of

Stan Hu added 1725 commits 8 years ago

added 1725 commits

01ad1d05...b88e82ff - 1724 commits from branch master
480b0866 - Add performance/scalability concerns to CONTRIBUTING.md

Compare with previous version

Stan Hu marked as a Work In Progress from 8 years ago

marked as a Work In Progress from 8c9a4ed3

Stan Hu added 2239 commits 7 years ago

added 2239 commits

480b0866...9ed3db91 - 2237 commits from branch master
d43410a2 - Add performance/scalability concerns to CONTRIBUTING.md
320a280e - Add documentation about using long polling

Compare with previous version

Stan Hu added 1 commit 7 years ago

added 1 commit

11dfad3e - Add performance/scalability concerns to CONTRIBUTING.md

Compare with previous version

Stan Hu unmarked as a Work In Progress 7 years ago

unmarked as a Work In Progress

Stan Hu assigned to @yorickpeterse 7 years ago

assigned to @yorickpeterse

Stan Hu @stanhu · 7 years ago

Author Maintainer

Updated with the latest information. Please take a look.

Stan Hu @stanhu started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by username-removed-378947

Stan Hu assigned to @adamniedzielski 7 years ago

assigned to @adamniedzielski

username-removed-378947 added 1 commit 7 years ago

added 1 commit

84561349 - Describe polling with ETag caching

Compare with previous version

username-removed-378947 @adamniedzielski · 7 years ago

Contributor

@stanhu I added the documentation for polling with ETag caching and pushed to your branch.

username-removed-378947 assigned to @stanhu 7 years ago

assigned to @stanhu

Stan Hu @stanhu · 7 years ago

Author Maintainer

Thanks, @adamniedzielski!

Stan Hu assigned to @yorickpeterse 7 years ago

assigned to @yorickpeterse

yorickpeterse-staging Approved this merge request 7 years ago

Approved this merge request

yorickpeterse-staging added ~15078 labels 7 years ago

added ~15078 backstage labels

Stan Hu assigned to @stanhu 7 years ago

assigned to @stanhu

Stan Hu @stanhu · 7 years ago

Author Maintainer

Spec failures are a transient failure. I'm going to merge this since this is just documentation.

Stan Hu merged 7 years ago

merged

Stan Hu mentioned in commit 7 years ago

mentioned in commit 281fcbcb

Please register or sign in to reply