Add runner version to /admin/runners view

What does this MR do?

This adds the runners' versions to the table in the runner admin view (/admin/runners).

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Addresses #14748 (moved)

Note: I'd also like to show it in the specific runner page (/admin/runners/<id>) but that view already has UX issues, and shares the top of the view with (<user>/<project>/runners/<id>/edit) (project/runners/_form.html.haml).

/spend 30m ....didn't work. Should I open an issue?

Hi @JonathonReinhart I couldn't reproduce with a regular Merge Request or a WIP Merge Request. Were there any JS errors in the dev tools console at the time?

added ~19173 ~164274 ~788703 labels

@JonathonReinhart Thanks for taking this issue on

unmarked as a Work In Progress

mentioned in issue #24141 (moved)

Since https://gitlab.com/gitlab-org/gitlab-ce/issues/24141 is underway, and that view is shared by /admin/runners/<id>, I think we can leave that part out. Personally, as a gitlab admin, just this minor tweak shown in the screenshot would be very helpful, and I'd love to see this merged.

mentioned in issue #27196 (closed)

Hi @JonathonReinhart I couldn't reproduce with a regular Merge Request or a WIP Merge Request. Were there any JS errors in the dev tools console at the time?

@markglenfletcher No JS errors. I think the problem is that I'm not a member of gitlab-org or gitlab-org/gitlab-ce. I opened issue #27196 (closed).

@markglenfletcher Is there any reason we can't merge this extremely simple, and useful change? I have been manually applying it to all of the GitLab instances I administer:

# wget https://gitlab.com/JonathonReinhart/gitlab-ce/commit/efaa87fda1ae9e55b8c7a711f11ff57f3c63aef4.diff
# patch -p1 -d /opt/gitlab/embedded/service/gitlab-rails --dry-run <  efaa87fda1ae9e55b8c7a711f11ff57f3c63aef4.diff
# gitlab-ctl restart unicorn

@JonathonReinhart I'm really sorry about the delay getting this one reviewed

Please could you add a changelog entry and we'll see how the builds get on

added 2754 commits

• efaa87fd...b29e4689 - 2753 commits from branch gitlab-org:master
• 99f5ed0e - Add runner version to /admin/runners view

Compare with previous version

marked the task Changelog entry added as completed

marked the task Conform by the style guides as completed

marked the task Squashed related commits together as completed

@markglenfletcher No worries. I rebased onto master and added the changelog entry. All tests are green.

@JonathonReinhart Great. Looks good to me

assigned to @rymai

@JonathonReinhart Thanks, looks good to me!

changed milestone to %9.0

merged

Thanks!