Skip to content
Snippets Groups Projects

lfs: do not require auth for public repositories

All threads resolved!

What does this MR do?

Allow LFS objects on public repos to be downloaded without authentication.

Are there points in the code the reviewer needs to double check?

Maybe?

Why was this MR needed?

LFS downloads on public repositories is obnoxious without this.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#23360 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-152826 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 6df7e2e0 - lfs: do not require auth for public repositories

    Compare with previous version

  • added 1 commit

    • e943e9b3 - lfs: do not require auth for public repositories

    Compare with previous version

  • username-removed-152826 marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • I don't know how to interpret the failures. Are they my fault?

  • username-removed-152826 marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • Ping? @stanhu Can you interpret the test results for me?

  • Maintainer

    Don't think so--you might want to retry failed.

  • username-removed-152826 marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • All tests are passing.

  • assigned to @rymai

  • added ~164274 lfs labels

  • added ~480950 label

  • @ben.boeckel Thanks, I had one remark, LGTM otherwise! :thumbsup:

  • added 1 commit

    • 5c20e50f - lfs: do not require auth for public repositories

    Compare with previous version

  • username-removed-152826 resolved all discussions

    resolved all discussions

  • username-removed-152826 marked the task All builds are passing as incomplete

    marked the task All builds are passing as incomplete

  • username-removed-152826 marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • Tests are passing.

  • @ben.boeckel Awesome work, thanks a lot!

  • added ~149423 label

  • changed milestone to %8.17

  • mentioned in commit 1a1381a4

  • Rubén Dávila removed ~149423 label

    removed ~149423 label

  • Picked into 8-17-stable, will go with 8.17 RC3

  • Please register or sign in to reply
    Loading