Skip to content
Snippets Groups Projects

Expose paginated environments list API endpoint

Merged Grzegorz Bizon requested to merge feature/gb/paginated-environments-api into master
All threads resolved!

What does this MR do?

This is a backend work needed to make a progress with #25499 (closed).

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug

What are the relevant issue numbers?

See https://gitlab.com/gitlab-org/gitlab-ce/issues/25499#note_22111741

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 888fba1e - Order environments twice in environments serializer

    Compare with previous version

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • 2150d98a - Add specs for environments serializer pagination
    • a5e5e4ac - Fix typo in pipeline serializer specs

    Compare with previous version

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 16a72896 - Extend environments folders and pagination API specs

    Compare with previous version

  • Grzegorz Bizon added 371 commits

    added 371 commits

    Compare with previous version

  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • Author Maintainer

    @adamniedzielski Can you please review? I still have to add some specs, but other than that this is ready for review 🙂

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • 10c1a4d8 - Rename Gitlab::Serialize module to reuse it later
    • 81eb5c7f - Move serializers pagination class to separate module

    Compare with previous version

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • a7420b77 - Add specs for standalone pagination for serializers

    Compare with previous version

  • Grzegorz Bizon marked the task Tests added for this feature/bug as completed

    marked the task Tests added for this feature/bug as completed

  • Author Maintainer

    @rymai Can you also take a look? Thanks in advance! 💜

  • username-removed-128633
  • Filipa Lacerda added 348 commits

    added 348 commits

    Compare with previous version

  • @grzesiek I absolutely love your tests, they make it super clear what I should expect in the code! 💯 I left some minor comments.

  • Grzegorz Bizon changed milestone to %9.0

    changed milestone to %9.0

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • e4cb073b - Simplify implementation of environments serializer

    Compare with previous version

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • 8753635c - Use #present? instead of defined? in serializers
    • e217bb21 - Make headers asserts explicit in pagination specs

    Compare with previous version

  • assigned to @rymai

  • Author Maintainer

    Thank you @adamniedzielski! I addressed your remarks! Let's pass this to @rymai.

    @rymai We moved this to 9.0 so feel free to review later, if you still have 8.17 stuff to review. Thanks in advance! 💜

    Edited by Grzegorz Bizon
  • username-removed-128633 resolved all discussions

    resolved all discussions

  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • username-removed-128633 resolved all discussions

    resolved all discussions

  • @grzesiek Awesome work, thank you! ❤️

  • mentioned in commit 0fc47429

  • Please register or sign in to reply
    Loading