Nested groups API (!9034) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged username-removed-444 requested to merge dz-nested-groups-api into master 8 years ago

1 unresolved thread

What does this MR do?

Allow creating nested groups via API
Expose Group#parent_id via API

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

People can work with nested groups via API

Does this MR meet the acceptance criteria?

Changelog entry added
Documentation created/updated
API support added
Tests
- Added for this feature/bug
- All builds are passing
Conform by the merge request performance guides
Conform by the style guides
Branch has no merge conflicts with master (if it does - rebase it please)
Squashed related commits together

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Activity

username-removed-444 mentioned in issue #2772 (closed) 8 years ago

mentioned in issue #2772 (closed)
username-removed-444 added 1 commit 8 years ago
added 1 commit

c16d3179 - Add nested groups to the API

Compare with previous version
username-removed-444 marked the task API support added as completed 8 years ago

marked the task API support added as completed
username-removed-444 marked the task Documentation created/updated as completed 8 years ago

marked the task Documentation created/updated as completed
username-removed-444 marked the task Changelog entry added as completed 8 years ago

marked the task Changelog entry added as completed
username-removed-444 added 1 commit 8 years ago
added 1 commit

2b4293ba - Add nested groups to the API

Compare with previous version
username-removed-444 added 1 commit 8 years ago
added 1 commit

df974814 - Add nested groups to the API

Compare with previous version
username-removed-444 added ~13884 label 8 years ago

added ~13884 label
username-removed-444 marked the task Added for this feature/bug as completed 8 years ago

marked the task Added for this feature/bug as completed
username-removed-444 marked the task All builds are passing as completed 8 years ago

marked the task All builds are passing as completed
username-removed-444 marked the task Conform by the merge request performance guides as completed 8 years ago

marked the task Conform by the merge request performance guides as completed
username-removed-444 marked the task Conform by the style guides as completed 8 years ago

marked the task Conform by the style guides as completed
username-removed-444 marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed 8 years ago

marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed
username-removed-444 marked the task Squashed related commits together as completed 8 years ago

marked the task Squashed related commits together as completed
username-removed-444 unmarked as a Work In Progress 8 years ago

unmarked as a Work In Progress
username-removed-444 @dzaporozhets · 8 years ago

Author Owner

@timothyandrew please review
username-removed-444 assigned to @timothyandrew 8 years ago

assigned to @timothyandrew
username-removed-2900 @razer6 started a thread on the diff 8 years ago

Resolved 8 years ago by username-removed-2900
Last reply by username-removed-2900 8 years ago

username-removed-2900 @razer6 started a thread on the diff 8 years ago

spec/requests/api/groups_spec.rb

         expect(json_response["request_access_enabled"]).to eq(group[:request_access_enabled])
       end
       it "creates a nested group" do

username-removed-444 mentioned in merge request !8786 (merged) 8 years ago

mentioned in merge request !8786 (merged)

username-removed-444 @dzaporozhets · 8 years ago

Author Owner

Hm looks like @timothyandrew is off today. @DouweM maybe you have time to review this MR?

username-removed-444 assigned to @DouweM 8 years ago

assigned to @DouweM

Douwe Maan @DouweM · 8 years ago

Maintainer

@dzaporozhets Code LGTM. Please check https://gitlab.com/gitlab-org/gitlab-ce/builds/10102161!

Douwe Maan assigned to @dzaporozhets 8 years ago

assigned to @dzaporozhets

username-removed-444 merged 8 years ago

merged

username-removed-444 mentioned in commit 8 years ago

mentioned in commit 3d206700

username-removed-444 added label 8 years ago

added subgroups label

Please register or sign in to reply