Skip to content

Remove istanbul

username-removed-408677 requested to merge remove-istanbul into master

TLDR: Temporarily remove istanbul until we figure out how to handle the license issue of it's sub sub sub dependency wordwrap@0.0.2.

We've chosen to temporarily remove javascript coverage reports in a different MR so that our builds continue to pass on master. As of right now, we still have a dependency on package.json called istanbul whos main purpose is to determine code coverage.

We wanted to keep it for later but it has some sub sub sub ... sub dependencies that do not have the correct license we need to make our license_finder happy. This dependency is wordwrap. wordwrap is currently at v1.0.0 which is a common sub-dependency for our other packages like eslint. Unfortunately istanbul's sub sub dependency uses wordwrap@0.0.2 which does not have the same license as the newest version.

As a result, we are going to temporarily remove istanbul from package.json for now

wordwrap@0.0.2 is a dependency of cliui@2.1.0
cliui@2.1.0 is a dependency of yargs@3.10.0
yargs@3.10.0 is a dependency of uglify-js@2.7.5
uglify-js@2.7.5 is a dependency of handlebars@4.0.6
handlebars@4.0.6 is a dependency of istanbul@0.4.5
└─┬ istanbul@0.4.5 
  ├── abbrev@1.0.9 
  ├── async@1.5.2 
  ├─┬ escodegen@1.8.1 
  │ ├── estraverse@1.9.3 
  │ ├── esutils@2.0.2 
  │ ├─┬ optionator@0.8.2 
  │ │ ├── deep-is@0.1.3 
  │ │ ├── fast-levenshtein@2.0.6 
  │ │ ├── levn@0.3.0 
  │ │ ├── prelude-ls@1.1.2 
  │ │ └── type-check@0.3.2 
  │ └─┬ source-map@0.2.0 
  │   └── amdefine@1.0.1 
  ├── esprima@2.7.3 
  ├─┬ glob@5.0.15 
  │ ├── inflight@1.0.6 
  │ ├── inherits@2.0.3 
  │ ├─┬ minimatch@3.0.3 
  │ │ └─┬ brace-expansion@1.1.6 
  │ │   ├── balanced-match@0.4.2 
  │ │   └── concat-map@0.0.1 
  │ └── path-is-absolute@1.0.1 
  ├─┬ handlebars@4.0.6 
  │ ├─┬ optimist@0.6.1 
  │ │ ├── minimist@0.0.10 
  │ │ └── wordwrap@0.0.3 
  │ ├── source-map@0.4.4 
  │ └─┬ uglify-js@2.7.5 
  │   ├── async@0.2.10 
  │   ├── source-map@0.5.6 
  │   ├── uglify-to-browserify@1.0.2 
  │   └─┬ yargs@3.10.0 
  │     ├── camelcase@1.2.1 
  │     ├─┬ cliui@2.1.0 
  │     │ ├─┬ center-align@0.1.3 
  │     │ │ ├─┬ align-text@0.1.4 
  │     │ │ │ ├─┬ kind-of@3.1.0 
  │     │ │ │ │ └── is-buffer@1.1.4 
  │     │ │ │ ├── longest@1.0.1 
  │     │ │ │ └── repeat-string@1.6.1 
  │     │ │ └── lazy-cache@1.0.4 
  │     │ ├── right-align@0.1.3 
  │     │ └── wordwrap@0.0.2 
  │     ├── decamelize@1.2.0 
  │     └── window-size@0.1.0 
  ├─┬ js-yaml@3.8.1 
  │ ├─┬ argparse@1.0.9 
  │ │ └── sprintf-js@1.0.3 
  │ └── esprima@3.1.3 
  ├─┬ mkdirp@0.5.1 
  │ └── minimist@0.0.8 
  ├── nopt@3.0.6 
  ├─┬ once@1.4.0 
  │ └── wrappy@1.0.2 
  ├── resolve@1.1.7 
  ├─┬ supports-color@3.2.3 
  │ └── has-flag@1.0.0 
  ├─┬ which@1.2.12 
  │ └── isexe@1.1.2 
  └── wordwrap@1.0.0

Merge request reports