Skip to content
Snippets Groups Projects

Add GFM support to nested groups

Merged username-removed-444 requested to merge dz-nested-groups-gfm-alt into master
All threads resolved!

What does this MR do?

  • Use new regex for user reference parsing that supports / in path
  • Allows mention of nested groups in gfm like @gitlab/subgroup

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

So you can mention nested group in gfm like @gitlab/subgroup

Screenshots (if relevant)

Screenshot_2017-02-13_13.36.27

Screenshot_2017-02-13_13.36.33

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Grzegorz Bizon
  • @dzaporozhets I left just a two questions! It looks good to me. Let's pass this MR to @rspeicher who is an endboss is also a GitLab Flavored Markdown expert.

  • username-removed-444 resolved all discussions

    resolved all discussions

  • @rspeicher please review and assign back to me.

  • Robert Speicher
  • username-removed-444 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 57bb6b1a - Add GFM support to nested groups

    Compare with previous version

  • username-removed-444 enabled an automatic merge when the pipeline for 57bb6b1a succeeds

    enabled an automatic merge when the pipeline for 57bb6b1a succeeds

  • added 210 commits

    Compare with previous version

  • username-removed-444 enabled an automatic merge when the pipeline for 2c55fd00 succeeds

    enabled an automatic merge when the pipeline for 2c55fd00 succeeds

  • @dzaporozhets I don't know if this is GFM in general, but the autocomplete doesn't work when you add /.

    If for example there is a group gitlab/software and another gitlab-org/software and you want to only see those form the gitlab group, when you write @gitlab/ the autocomplete stops working.

    Edited by Achilleas Pipinellis
  • @axil thanks, please create an issue.

  • Please register or sign in to reply
    Loading