Nested groups improvements pt 3
What does this MR do?
- Expose Namespace#full_path to namespaces API
- Uses Namespace#full_path instead of Namespace#path where it makes sense
Are there points in the code the reviewer needs to double check?
no
Why was this MR needed?
This is necessary to make nested groups works properly like:
- transfer project inside nested group
- import project inside nested group
- filter projects on admin area by namespace
Screenshots (if relevant)
no
Does this MR meet the acceptance criteria?
Changelog entry added-
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
1154 1156 # All web servers convert hostname to lowercase 1155 host = "#{namespace.path}.#{Settings.pages.host}".downcase 1157 host = "#{subdomain}.#{Settings.pages.host}".downcase 1156 1158 1157 1159 # The host in URL always needs to be downcased 1158 1160 url = Gitlab.config.pages.url.sub(/^https?:\/\//) do |prefix| 1159 "#{prefix}#{namespace.path}." 1161 "#{prefix}#{subdomain}." 1160 1162 end.downcase 1161 1163 1162 1164 # If the project path is the same as host, we serve it as group page 1163 return url if host == path 1165 return url if host == url_path 1166 1167 "#{url}/#{url_path}" 1168 end @nick.thomas my goal here is to prevent bugs rather than make Pages works for nested projects. Can you review this method change and tell me what you think?
mentioned in issue #2772 (closed)
added 1 commit
- 3674b4ba - Use Namespace#full_path instead of Namespace#path
marked the task Squashed related commits together as completed
marked the task Conform by the style guides as completed
marked the task Conform by the merge request performance guides as completed
added 1 commit
- 6676b4f0 - Use Namespace#full_path instead of Namespace#path
added 78 commits
-
6676b4f0...ad5e772b - 77 commits from branch
master
- efc82ebf - Merge branch 'master' into 'dz-nested-groups-improvements-3'
-
6676b4f0...ad5e772b - 77 commits from branch
enabled an automatic merge when the pipeline for efc82ebf succeeds
added subgroups label
added 12 commits
-
efc82ebf...b4c00ae4 - 11 commits from branch
master
- dcdab2ae - Merge remote-tracking branch 'origin/master' into dz-nested-groups-improvements-3
-
efc82ebf...b4c00ae4 - 11 commits from branch
enabled an automatic merge when the pipeline for dcdab2ae succeeds