Skip to content
Snippets Groups Projects

Nested groups improvements pt 3

Merged username-removed-444 requested to merge dz-nested-groups-improvements-3 into master
1 unresolved thread

What does this MR do?

  • Expose Namespace#full_path to namespaces API
  • Uses Namespace#full_path instead of Namespace#path where it makes sense

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

This is necessary to make nested groups works properly like:

  • transfer project inside nested group
  • import project inside nested group
  • filter projects on admin area by namespace

Screenshots (if relevant)

no

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1154 1156 # All web servers convert hostname to lowercase
1155 host = "#{namespace.path}.#{Settings.pages.host}".downcase
1157 host = "#{subdomain}.#{Settings.pages.host}".downcase
1156 1158
1157 1159 # The host in URL always needs to be downcased
1158 1160 url = Gitlab.config.pages.url.sub(/^https?:\/\//) do |prefix|
1159 "#{prefix}#{namespace.path}."
1161 "#{prefix}#{subdomain}."
1160 1162 end.downcase
1161 1163
1162 1164 # If the project path is the same as host, we serve it as group page
1163 return url if host == path
1165 return url if host == url_path
1166
1167 "#{url}/#{url_path}"
1168 end
  • mentioned in issue #2772 (closed)

  • added 1 commit

    • 3674b4ba - Use Namespace#full_path instead of Namespace#path

    Compare with previous version

  • username-removed-444 marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • username-removed-444 marked the task Conform by the style guides as completed

    marked the task Conform by the style guides as completed

  • username-removed-444 marked the task Conform by the merge request performance guides as completed

    marked the task Conform by the merge request performance guides as completed

  • added 1 commit

    • 6676b4f0 - Use Namespace#full_path instead of Namespace#path

    Compare with previous version

  • username-removed-444 marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • added 78 commits

    Compare with previous version

  • username-removed-444 enabled an automatic merge when the pipeline for efc82ebf succeeds

    enabled an automatic merge when the pipeline for efc82ebf succeeds

  • username-removed-444 marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • added 12 commits

    • efc82ebf...b4c00ae4 - 11 commits from branch master
    • dcdab2ae - Merge remote-tracking branch 'origin/master' into dz-nested-groups-improvements-3

    Compare with previous version

  • username-removed-444 enabled an automatic merge when the pipeline for dcdab2ae succeeds

    enabled an automatic merge when the pipeline for dcdab2ae succeeds

  • Please register or sign in to reply
    Loading