style links on system notes to look clickable
What does this MR do?
Make Compare with previous version and Toggle commit list look like links
Are there points in the code the reviewer needs to double check?
After clicking Toggle commit list the hover style is still applied until mouse moves. Not related to this though
Why was this MR needed?
Didn't look clickable before
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #27959 (closed)
Merge request reports
Activity
@psimyn this looks good to me but there's only one thing I think we can fix right now.
When I click the arrow icon the expand/collapse doesn't work. This is easily fixable by changing
const $element = $(e.target);toconst $element = $(e.currentTarget);onNotes.prototype.toggleCommitList.Just fix that and it should be ready to go.
assigned to @psimyn
added 1 commit
- 67d88245 - allow clicking on text or icon to trigger expand
Thank you @psimyn LGTM!
enabled an automatic merge when the pipeline for 67d88245 succeeds
added 61 commits
-
67d88245...5ad1d40c - 59 commits from branch
master - 7b69580e - style links on system notes to look clickable
- 0fe942c6 - allow clicking on text or icon to trigger expand
-
67d88245...5ad1d40c - 59 commits from branch
enabled an automatic merge when the pipeline for 0fe942c6 succeeds
