Skip to content
Snippets Groups Projects

Make nested groups deletion synchronous to avoid potential race

Merged Stan Hu requested to merge sh-async-delete-children into master

There may be a potential race condition in the group deletion. Suppose there is a namespace test with nested group foo:

  1. Namespace test is queued for deletion
  2. Namespace test schedules foo for deletion
  3. Namespace test is destroyed
  4. Namespace foo finds no parent, so it may fail

Didn't have time to write a spec for this, but I wanted to raise this as a potential issue.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading